-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO: Show modal on disconnection #88552
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~716 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
import classNames from 'classnames'; | ||
import cookie from 'cookie'; | ||
import PropTypes from 'prop-types'; | ||
import { useState } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the one from @WordPress?
This is great, thanks! Let's show the modal only for en users for now (as the CrowdSignal survey will be in English)! And create the survey on Crowdsignal before shipping this :D |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
It looks very nice, @heavyweight, just two things. The "Remind later" should also appear in blue. A few hours ago, we made some changes to the design of those pop-ups so that when they display an image, we don't include the top header. Sorry for this last-minute change! Link to the design: eqlepL7MHifK8Bgr1OWqLr-fi-15013_60324 |
Hi Javier, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11607014 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @heavyweight, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Co-authored-by: Anthony Grullon <[email protected]>
This PR adds
SurveyModal
component and uses that to display a modal when users disable ssoRelated to #
Proposed Changes
Testing Instructions
Pre-merge Checklist