Plans 2023: Remove hardcoded feature flags for flows with hidden plan type selector

[jeyip]

Related to https://github.com/Automattic/growth-foundations/issues/305

Proposed Changes

• The new plan type selector dropdown was disabled for all others flows except for signup flows. The flags, however, are unnecessary for flows that hide the plan type selector anyway ( as evidenced by the hidePlanTypeSelector prop passed to each of the plans grids note below )

Testing Instructions

WooExpress flow plans page

• Visit WordPress.com/setup/wooexpress
• Wait for the site to generate
• Navigate to /plans
• Smoke test the plans grid. Note that the WooExpress plans page renders its own custom plan type selector with a monthly / 1 year toggle. It should still behave as it does in production.

P2 flow plans page

• Visit /start/p2
• Generate a p2 workspace
• Navigate to /plans/{new_p2_workspace_site_slug}
• Smoke test the plans grid. Everything should behave as it currently does in production.

Jetpack App flow

• Follow testing instructions noted in this PR Task: Create Plans page for Jetpack App Site Creation #82135
• Visit WordPress.com/jetpack-app/plans
• Desktop view is broken, but I believe that is expected? This view is meant primarily for a mobile experience
• Verify that the plans grid in the mobile view continues to behave as expected

Business Trial Plans Page

• All trial pages share a single UI view, which can be tested following the instructions in this PR Add of Migration Trials and initial refactoring of Ecommerce Trial components #80095
  • Create a jurassic.ninja site
  • Install Move to WordPress.com plugin
  • Click on Migrate site to WordPress.com CTA
  • Migrate site to WordPress.com
  • Visit the upgrades > plans page for the newly created WordPress.com site
  • Smoke test the plans grid. Everything should behave as it currently does in production.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-95713

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-95713&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~83 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
plans             -240 B  (-0.0%)      -33 B  (-0.0%)
jetpack-app       -127 B  (-0.0%)      -50 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jeyip]

Testing

Requirements

WooExpress flow plans page

• Smoke test the plans grid. Note that the WooExpress plans page renders its own custom plan type selector with a monthly / 1 year toggle. It should still behave as it does in production.

P2 flow plans page

• Smoke test the plans grid. Everything should behave as it currently does in production.

Jetpack App flow

• Desktop view is broken, but I believe that is expected? This view is meant primarily for a mobile experience
• CTAs don't work but they're also currently broken in production

• Verify that the plans grid in the mobile view continues to behave as it already does in production

Business Trial Plans Page

• Smoke test the plans grid. Everything should behave as it currently does in production.

Browsers

• Edge
• Firefox
• Safari
• Chrome