Stats: Trash pickup of old localStore usage. #8338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to remove a few remaining uses of
store
within Stats code. At one point we wanted to keep track of the dates users had been visiting stats pages -statsVisitDates
is no longer used and has been removed from the controller logic here.The other bit of logic is to track which tab in the stats chart was last focused. As we do further redux work in stats, we might consider adding a
ui
state tree for this aspect of stats, but I feel defaulting to 'Views' in the stats chart is fine personally.To Test