Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Trash pickup of old localStore usage. #8338

Merged
merged 1 commit into from
Sep 30, 2016

Conversation

timmyc
Copy link
Contributor

@timmyc timmyc commented Sep 29, 2016

This PR seeks to remove a few remaining uses of store within Stats code. At one point we wanted to keep track of the dates users had been visiting stats pages - statsVisitDates is no longer used and has been removed from the controller logic here.

The other bit of logic is to track which tab in the stats chart was last focused. As we do further redux work in stats, we might consider adding a ui state tree for this aspect of stats, but I feel defaulting to 'Views' in the stats chart is fine personally.

To Test

  • Load up the stats overview page http://calypso.localhost:3000/stats - ensure it loads as expected
  • Click through to a site listed there, ensure the site stats page loads properly

@timmyc timmyc added [Feature] Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Sep 29, 2016
@timmyc timmyc self-assigned this Sep 29, 2016
@matticbot
Copy link
Contributor

@timmyc
Copy link
Contributor Author

timmyc commented Sep 29, 2016

/cc @mtias this pulls out the last usage of localStorage in stats.

@mtias
Copy link
Member

mtias commented Sep 30, 2016

Looks good to me. (Switching sites seems a bit laggy to me on this PR, but may just be my browser that's been crawling lately.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/ [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants