Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans page for Jetpack App: Handle all unhandled jetpack-app/* routes by showing 404 page #82979

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Oct 13, 2023

Related to #82135

Handle all unhandled jetpack-app/* routes by showing a 404 page

Proposed Changes

  • Use EmptyContent component with images, titles, and descriptions from similar empty content components
  • Keep default styles
  • Reuse existing translations
404.not.found.page.mov

Testing Instructions

  • jetpack-app/ should continue routing to jetpack-app/plans
  • jetpack-app/plans should continue displaying Plans page with wp-iphone and wp-android user agent
  • jetpack-app/* routes should display 404 page

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

Using EmptyContent with already used translations and images
@staskus staskus added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Mobile Application WordPress.com App for mobile labels Oct 13, 2023
@staskus staskus requested a review from tyxla October 13, 2023 08:25
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

@matticbot
Copy link
Contributor

matticbot commented Oct 13, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~143 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
jetpack-app       +383 B  (+0.1%)     +143 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works well. Thanks 🚀

@staskus staskus merged commit a2d0d53 into trunk Oct 13, 2023
@staskus staskus deleted the task/plans-page-for-jetpack-app-handle-all-routes branch October 13, 2023 11:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Application WordPress.com App for mobile [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants