Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Task: Create Plans page for Jetpack App Site Creation #82404

Closed
wants to merge 23 commits into from
Closed

[Draft] Task: Create Plans page for Jetpack App Site Creation #82404

wants to merge 23 commits into from

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Sep 29, 2023

This is a PR to make a build and test some changes to #82135

staskus and others added 18 commits September 25, 2023 18:56
@staskus
Create a basic structure for /jetpack-app-plans page
d0f33a4 
- Created jetpack-app-plans directory
- Added an entry into sections.js with a path and module
- Created controller.jsx that displays JetpackAppPlans component and passes query parameters
- Created index.js defining a page and including jetpackAppPlans controller
- Created main.jsx that shows a loading indicator while querying plans, and PlansFeaturesMain component once plans are loaded
- Created style.scss with jetpack-app-plans style that includes plan-features-layout-switcher to support media queries when displaying plans grid
@guarani
Remove use of deprecated params
b02dc10
@staskus
Set intent for Jetpack app plans in site creation
c5cfdc1
@staskus
Hide yearly/monthly selector
377e11f
@staskus
Pass selected plan through redirection url
3c896d6 
- Allow redirect_to parameter to URL which is then used to callback with a selected plan
- Do not pass selected plan if free plan is selected
@staskus
Use snake case for passing cart item
45e88f7
@staskus
Merge branch 'trunk' into task/82131-create-plans-page-for-jetpack-ap…
15d3f53 
…p-site-creation
@guarani
Fix plan retrieval from cart
07e5c4a 
Use getPlanCartItem to get plan
@staskus
Check if cartItems exist before fetching plan
0c741da
@staskus
Hide top and sidebars in jetpack-app-plans flow
20b2a8e
@staskus
Add a header to jetpack-app-plans page
46c9d1f
@staskus
Refactor to improve code style
a2cc114
@staskus
Show a different header label when no domain name is passed
362bac9
@staskus
Hide feature comparison
60a48a9
@staskus
Rename domain_name to paid_domain_name for more clarity
ce04567
@staskus
Reuse the same translation from previous label
d4109ec
@staskus
Merge branch 'trunk' into task/82131-create-plans-page-for-jetpack-ap…
86616c6 
…p-site-creation
@staskus
Renaming plans-grid path
864bfe0
@staskus staskus self-assigned this Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Sep 29, 2023 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-83247
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-83247&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Sep 29, 2023 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~145 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +2293 B  (+0.1%)     +145 B  (+0.0%)
entry-main                 +2293 B  (+0.1%)     +142 B  (+0.0%)
entry-subscriptions         +108 B  (+0.0%)      +44 B  (+0.0%)
entry-login                 +108 B  (+0.0%)      +44 B  (+0.0%)
entry-domains-landing       +108 B  (+0.0%)      +44 B  (+0.0%)
entry-browsehappy           +108 B  (+0.1%)      +44 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~21928 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
jetpack-app-plans       +611331 B    (new)  +186747 B    (new)
update-design-flow          +78 B  (+0.0%)      +17 B  (+0.0%)
plugins                     +78 B  (+0.0%)      +17 B  (+0.0%)
plans                       +78 B  (+0.0%)      +17 B  (+0.0%)
link-in-bio-tld-flow        +78 B  (+0.0%)      +17 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~17 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +78 B  (+0.0%)      +17 B  (+0.0%)
async-load-signup-steps-plans                          +78 B  (+0.0%)      +17 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

This was referenced Oct 2, 2023
Closed
Closed
@staskus staskus force-pushed the task/82131-create-plans-page-for-jetpack-app-site-creation-test branch from 16f967e to 01afb54 Compare October 2, 2023 11:12
@staskus staskus mentioned this pull request Oct 4, 2023
Merged
13 tasks
@staskus staskus closed this Oct 6, 2023
@staskus staskus deleted the task/82131-create-plans-page-for-jetpack-app-site-creation-test branch October 6, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@staskus staskus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staskus @matticbot @guarani