-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the GlobalStylesContext type for typescript 5 #79722
Fix the GlobalStylesContext type for typescript 5 #79722
Conversation
Link to live branch is being generated... |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
1c3eaa2
to
d5bcb32
Compare
d5bcb32
to
23bbefe
Compare
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~108 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~411 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~424 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful, thanks!
* Fix the GlobalStylesContext type
* Fix the GlobalStylesContext type
* Update typescript to 5.1 * Update @typescript-eslint to latest v5 release to support ts 5.1 * Update popperjs to fix type issue * Update emotion for compatibility with Typescript 5 * Fix the GlobalStylesContext types for typescript 5 (#79722) * Fix unspecific type parameter to isObjKey * Fix implementation details for Report * Fix BaseButton type issue - Use wrapper fn to handle issues with isValidElement * Use type parameter to fix cloneElement issues * Fix issue where Typescript doesn't infer generic correctly - This applies to createSelector and treeSelect * Add wrapper type to handle error catch * Fix another HoC OuterProps issue
Related to #
Proposed Changes
@automattic/global-stypes
package@popperjs/core
package to resolve the error below. Thereakit
has a breaking changes, and I think it's not a great timing to upgrade it as well.Testing Instructions
yarn build-packages
and you should not see the errorsPre-merge Checklist