Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Remove unnecessary top margin in form in Edit Card Details page #7555

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Purchases: Remove unnecessary top margin in form in Edit Card Details page #7555

merged 1 commit into from
Aug 22, 2016

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Aug 19, 2016 •
edited
Loading

Fixes #839.

This PR removes the additional top margin on the Edit Card Details page.

Before

screen shot 2016-08-19 at 18 24 37
screen shot 2016-08-19 at 18 24 51

After

screen shot 2016-08-19 at 18 23 46
screen shot 2016-08-19 at 18 24 01

No change

screen shot 2016-08-19 at 19 02 10

Testing

  1. Go to Manage Purchases page (http://calypso.localhost:3000/purchases).
  2. Select a purchase paid with credit card.
  3. Click on Edit Payment Method link.
  4. Check if top margin was removed.
  5. You can also test if credit card form in the checkout flow looks properly.

Test live: https://calypso.live/?branch=fix/839-margin-credit-card

@gziolo gziolo added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Aug 19, 2016
@gziolo gziolo self-assigned this Aug 19, 2016
@gziolo gziolo added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 19, 2016
@gziolo gziolo force-pushed the fix/839-margin-credit-card branch from 5e9a0d9 to 166cf13 Compare August 19, 2016 17:05
@gziolo
Copy link
Member Author

gziolo commented Aug 19, 2016

/cc @stephanethomas @breezyskies @Automattic/sdev-feed

@breezyskies
Copy link
Contributor

breezyskies commented Aug 19, 2016 •
edited
Loading

Design and code 👍

@breezyskies breezyskies added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 19, 2016
@gziolo gziolo merged commit 021bba3 into master Aug 22, 2016
@gziolo gziolo deleted the fix/839-margin-credit-card branch August 22, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gziolo gziolo

Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purchases: Remove unnecessary top margin in form in Edit Card Details page
2 participants
@gziolo @breezyskies