Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: allow hiding free plan on 2023 pricing grid #75446

Closed
wants to merge 1 commit into from

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Apr 7, 2023

On #75424, we're fixing the bug that prevented the free plan from being hidden. However, we missed removing the gate behind the hideFreenPlan variable. This PR opens the gate since the issue is fixed.

@zaguiini zaguiini requested review from claudiucelfilip and a team April 7, 2023 22:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 7, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~25 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
signup        -82 B  (-0.0%)      -25 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@claudiucelfilip
Copy link
Contributor

@zaguiini Thanks for catching this! However, this change will remove the Free plan if the user selects Choose my domain later on the domains step.
This behavior (to keep the Free plan) has been introduced here because of the missing features issue, but it's also an intended behavior, with the main onboarding flow at least.
The situation is being tackled in this thread: p9Jlb4-6HH-p2.

@zaguiini
Copy link
Contributor Author

Oh, I see, @claudiucelfilip, so that's actually intended behavior. Let me close this PR then!

@zaguiini zaguiini closed this Apr 10, 2023
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants