Remove unused gutenboarding script #74539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
tyxla
approved these changes
Mar 17, 2023
noahtallen
force-pushed
the
remove-gutenboarding-script
branch
from
0e5cef8 to
1231b45
Compare
noahtallen
commented
Mar 17, 2023
| @@ -40,24 +40,3 @@ yarn install | |||
| ``` | |||
|
|
|||
| Once complete, running `git commit` should no longer trigger the git pre-commit hook error. | |||
|
|
|||
| ## Package 'lcms2', required by 'vips', not found | |||
There was a problem hiding this comment.
This won't be an issue any more :D
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I think this script has been unused for a while. It was added for some aspects of gutenboarding, which is no longer used (#74475). This lets us remove a dependency on
sharp, which has been problematic in the past (#55292). And I noticed it causing issues with the latest typescript update, so it'd be nice to remove it.Testing Instructions
None; CI should pass. Also verify
sharpisn't imported elsewhere.