Migrate block editor nux to createReduxStore #74454
Conversation
matticbot
added
the
[Status] Needs Review
|
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
| @@ -153,16 +147,10 @@ function WelcomeTour( { siteIntent }: { siteIntent?: string } ) { | |||
| tourRating: { | |||
| enabled: true, | |||
| useTourRating: () => { | |||
There was a problem hiding this comment.
this use of hooks is interesting 🤔
There was a problem hiding this comment.
They told us React was "just JavaScript", so why not hooks as config 😄
There was a problem hiding this comment.
haha, fair enough! It stood out since I hadn't seen hooks used like this before :P
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
| @@ -153,16 +147,10 @@ function WelcomeTour( { siteIntent }: { siteIntent?: string } ) { | |||
| tourRating: { | |||
| enabled: true, | |||
| useTourRating: () => { | |||
There was a problem hiding this comment.
They told us React was "just JavaScript", so why not hooks as config 😄
| actions, | ||
| selectors, | ||
| controls, | ||
| persist: true, // TODO @noahtallen: persist plugin probably doesn't work here. |
There was a problem hiding this comment.
We do persist store data. This is it what the store looks like without the ETK patch.
And we do rely on it for caching so we're not always fetching the "should they see the welcome tour" flag from the server forever into the future.
And you're right it no longer appears to work with this patch applied.
There was a problem hiding this comment.
Unfortunate! I think the persist plugin may not have been migrated to work with the new store registration, so that may require more work before we can migrate this one.
Thanks for taking a look!
There was a problem hiding this comment.
for context, the persistence plugin definitely isn't compatible with the more modern registration methods :( See WordPress/gutenberg#11449
Another question is whether we could use the editor preferences layer instead, which does support browser persistence
|
Labeling as blocked until we get more info on what to do about the persistence plugin |
noahtallen
force-pushed
the
migrate-nux-to-crs
branch
from
4400ee2 to
5137bf3
Compare
see #74399 for more info
Proposed Changes
Migrates the block editor nux (new user experience) ETK feature to
createReduxStoreWhile there are other references to
automattic/wpcom-welcome-guidein the codebase, they're in different webpack bundles, so I continued using the string-based store identifier approach.Testing Instructions
TBD... you definitely start by syncing ETK. Create a new account and sandbox the new test site. At that point it might show up?
Added a couple people who recently touched these files for tips and maybe a review ;)