Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etk] Remove deprecated hide-plugin-buttons-mobile fix #67283

Conversation

fullofcaffeine
Copy link
Contributor

Proposed Changes

Follow up to: #49329

Further context: p1661852852314429-slack-C7YPUHBB2

I don't think this fix is needed anymore. I did a quick test here, and it seems the display: none is not even being applied anymore, being superseded by other rules in core GB. Notice how the blue background is applied, but the element is still visible:

Peek.2022-09-01.13-00.mp4

Thanks @simison for reaching out about this.

Testing Instructions

  • Checkout branch, sandbox a test site, and run yarn dev --sync
  • Open a post or page in the block editor
  • Shrink viewport down to mobile size and observe the plugin buttons disappear (they should still be available in the more menu)
  • The menu layout should not break.

Pre-merge Checklist

@fullofcaffeine fullofcaffeine requested a review from a team September 1, 2022 18:10
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit remove/collapse-plugin-icons-on-mobile-deprecated-fix on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 1, 2024
@simison simison deleted the remove/collapse-plugin-icons-on-mobile-deprecated-fix branch July 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants