-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPT: Display post author in custom post types list #6686
Conversation
@folletto and I were just discussing this, I agree with his comment: I feel unnecessary to provide that functionality in the card - this is meant to be a quick overview, before the user takes the primary action of editing the entry. The avatar, even tho it's a logical addition, feels too heavy in that meta information list - specially in the second position, it adds a visual weight to the middle of the card that takes attention away from the intended hierarchy in the card). Also, at such small size, it becomes a blur :) Let's ditch it and use the icon I used in the mockup, please. |
I also think providing the ability to change authorship here is more confusing than helpful. Changing the author of a post is a very uncommon operation (0.08% of |
Checked on Chrome, design wise it's 👍 (We should remove the "(last updated)" bit, but can be done in a separate PR, no need here) |
@hugobaeta mentioned this once before, and it's always been part of the underlying |
Yeah. I think we can get away from that, we might replace later with a tooltip, but the date is the latest update (or, publish in case of published posts) so it should be contexually clear what that is. :) |
See #6707 for removal of last modified label. |
Looks good & works well. Could use a rebase but otherwise good to go. |
fdff9a6
to
5c3cd19
Compare
This pull request seeks to add the post's author to the meta information on the custom post types list screen.
It also enables changing the author inline, making use of the existing(Removed per feedback)<AuthorSelector />
component (used also in the post editor).See original concept
Original version with author selector
Testing instructions:
Verify that you are able to view the author of a post, and reassign the author if you have capabilities for doing so.
If capabilities exist, note that a chevron is shown adjacent the author to select a new authorSelect a new authorNote that after a brief delay, the author is changed and persists through page refreshCaveats / Follow-up Tasks:
These caveats are no longer applicable after removal of author selector per feedback.
author
is different between reading and updating endpoints. This should be resolved by normalizing the post object's author in thegetNormalizedPost
selector.<AuthorSelector />
component.Test live: https://calypso.live/?branch=add/cpt-assign-author