Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPT: Adjust placement of thumbnail and action items on list screen #6572

Merged
merged 3 commits into from
Jul 8, 2016

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Jul 6, 2016

Closes #6540
Closes #6542

This pull request seeks to...

  • Adjust the position of the post thumbnail relative to the action menu
  • Reorder the action menu items to mirror that of the posts screen
  • Use "Preview" as View action label unless post is published

Incidentally, it also increases the clickable area of the menu toggle button.

Before After
Before After

Testing instructions:

  1. Navigate to the custom post types list screen
  2. Confirm that layout of thumbnail and menu match that as described in CPT: List View: Canonical Image size, position, and crop adjustment #6542
  3. Toggle the action menu for a post
  4. Confirm that menu items show in same order as on the posts screen
  5. Verify that "Preview" is shown for drafts or scheduled posts, and that "View" is shown for published or privately published posts (and is not an option for trashed posts)

/cc @hugobaeta

Test live: https://calypso.live/?branch=update/6540-6542-cpt-list-layout

@aduth aduth added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Custom Post Types (CPT) labels Jul 6, 2016
@folletto
Copy link
Contributor

folletto commented Jul 8, 2016

Tested on Chrome, Safari, Firefox 👍

Design wise it's good. Excellent enlargement of the ••• area.

A transversal comment not related to this PR: would be ideal that the image, when present, was clickable too. :)

@aduth
Copy link
Contributor Author

aduth commented Jul 8, 2016

would be ideal that the image, when present, was clickable too. :)

I agree! #6327

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 8, 2016
@aduth aduth merged commit 5123ead into master Jul 8, 2016
@aduth aduth deleted the update/6540-6542-cpt-list-layout branch July 8, 2016 18:18
@hugobaeta
Copy link

hugobaeta commented Jul 9, 2016

@aduth I agree, but not to enlarge the thumbnail. Clicking it should do the same as clicking the title: go to the edit screen. What do you think @folletto?

@folletto
Copy link
Contributor

Clicking it should do the same as clicking the title: go to the edit screen.

Yep! 👍

@folletto
Copy link
Contributor

Actually @mtias pointed out that would be a regression. I added then a quick iteration on #6327 to keep the feature in for the new design, if you want to review it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants