Sharing: Gracefully fail on bad message JSON #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Sharing
|
LGTM |
timmyc
added
[Status] Ready to Merge
and removed
[Status] Needs Review
This was referenced Mar 16, 2020
This was referenced Nov 17, 2020
This was referenced Mar 30, 2021
This was referenced Sep 15, 2021
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an error which can occur in some cases when a
postmessagecontaining a non-JSON-formatted message could result in an error in the sharing buttons preview frame handler.Testing instructions:
Verify that no regressions occur in the usage of the sharing buttons preview, including previewing (notably "Official" button style where iframe is in use) and updating buttons.
Test live: https://calypso.live/?branch=fix/media-bad-message-handling