-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCSS mixins: long-content-fade
to apply gradient from transparent
to color
#65598
SCSS mixins: long-content-fade
to apply gradient from transparent
to color
#65598
Conversation
overflow-gradient
to apply gradient from transparent
to color
overflow-gradient
to apply gradient from transparent
to colorlong-content-fade
to apply gradient from transparent
to color
long-content-fade
to apply gradient from transparent
to colorlong-content-fade
to apply gradient from transparent
to color
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as you described, I had tested the gutenberg one before also. The screenshots almost had me fooled 😅 . I was looking at the search bar wondering whats the difference, it draws the attention because its highlighted.
Looks good and works as expected. Just a note - currently the other branch has a conflict. I needed to solve conflicts after merging |
9401533
to
978ecdb
Compare
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me. 👍
Why can't we use the Gutenberg version directly, though?
For a couple of reasons, @noahtallen:
It can be done, but I'd prefer to do that on a separate PR. We'd first need to isolate the |
Cool! That makes sense to me. One thing that comes to mind is that the way Sass imports work will be changing in the near future. I believe that Gutenberg is not yet compatible with the new approach, nor is Calypso. But in the new system, imports are now namespaced, so using just one mixin by itself should be possible without impacting any other mixins. Upgrading Gutenberg and Calypso to support that has been on my todo list for a while, but there have been other priorities :) |
Proposed Changes
Sync our version of
long-content-fade
with Gutenberg's.This PR will be good to go once the next version of
@wordpress/base-styles
is merged. This PR will also bump the package's version.Testing Instructions
Open Calypso, click
Switch Sites
and you should see the gradient working on the edge for long site URLs. Amazingly, this does not work ontrunk
:trunk
Related to #65505 (comment).