fix(deps): update wordpress monorepo

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@wordpress/a11y	^3.2.2 -> ^3.2.3
@wordpress/api-fetch	^5.2.2 -> ^5.2.5
@wordpress/base-styles	^4.0.0 -> ^4.0.3
@wordpress/block-editor	^7.0.2 -> ^8.0.0
@wordpress/blocks	^11.1.0 -> ^11.1.3
@wordpress/components	^17.0.0 -> ^19.0.1
@wordpress/compose	^5.0.2 -> ^5.0.5
@wordpress/data	^6.1.0 -> ^6.1.3
@wordpress/data-controls	^2.2.3 -> ^2.2.6
@wordpress/date	^4.2.1 -> ^4.2.2
@wordpress/deprecated	^3.2.1 -> ^3.2.2
@wordpress/dom-ready	^3.2.1 -> ^3.2.2
@wordpress/edit-post	^5.0.2 -> ^5.0.5
@wordpress/edit-site	^3.0.2 -> ^3.0.5
@wordpress/editor	^11.0.2 -> ^12.0.2
@wordpress/element	^4.0.1 -> ^4.0.3
@wordpress/env	^4.1.1 -> ^4.1.3
@wordpress/escape-html	^2.2.1 -> ^2.2.2
@wordpress/eslint-plugin	^9.1.2 -> ^9.2.0
@wordpress/format-library	^3.0.2 -> ^3.0.5
@wordpress/hooks	^3.2.0 -> ^3.2.1
@wordpress/html-entities	^3.2.1 -> ^3.2.2
@wordpress/i18n	^4.2.2 -> ^4.2.3
@wordpress/icons	^5.0.2 -> ^6.1.0
@wordpress/jest-preset-default	^7.1.1 -> ^7.1.2
@wordpress/keycodes	^3.2.2 -> ^3.2.3
@wordpress/nux	^5.0.2 -> ^5.0.5
@wordpress/plugins	^4.0.2 -> ^4.0.5
@wordpress/primitives	^3.0.1 -> ^3.0.3
@wordpress/react-i18n	^3.0.1 -> ^3.0.3
@wordpress/rich-text	^5.0.2 -> ^5.0.5
@wordpress/scripts	^18.0.1 -> ^19.1.0
@wordpress/server-side-render	^3.0.2 -> ^3.0.5
@wordpress/url	^3.2.2 -> ^3.3.0
@wordpress/viewport	^4.0.2 -> ^4.0.5
@wordpress/warning	^2.2.1 -> ^2.2.2

---

Release Notes

WordPress/gutenberg

v3.2.3

Compare Source

---

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[github-actions]

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-19898
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-19898&env=jetpack

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit renovate/wordpress-monorepo on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~66393 bytes added 📈 [gzipped])

name                   parsed_size            gzip_size
entry-gutenboarding      +221789 B  (+11.6%)   +66494 B  (+12.0%)
entry-main                  -416 B   (-0.0%)     -167 B   (-0.0%)
entry-login                 -147 B   (-0.0%)      -71 B   (-0.0%)
entry-domains-landing        -74 B   (-0.0%)      -58 B   (-0.0%)
entry-browsehappy            -55 B   (-0.1%)      -48 B   (-0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6673 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
jetpack-connect                   -5512 B  (-0.9%)    -1800 B  (-1.0%)
marketing                         -5110 B  (-0.8%)    -1604 B  (-0.9%)
site-blocks                       -5069 B  (-1.3%)    -1610 B  (-1.5%)
security                          -5069 B  (-1.0%)    -1614 B  (-1.1%)
privacy                           -5069 B  (-1.5%)    -1684 B  (-1.7%)
me                                -5069 B  (-1.5%)    -1653 B  (-1.7%)
help                              -5069 B  (-1.0%)    -1612 B  (-1.1%)
happychat                         -5069 B  (-1.5%)    -1662 B  (-1.7%)
account-close                     -5069 B  (-1.4%)    -1671 B  (-1.6%)
settings-writing                  -5061 B  (-0.9%)    -1358 B  (-0.8%)
media                             -5039 B  (-0.3%)     -579 B  (-0.1%)
posts                             -4994 B  (-1.0%)    -1492 B  (-1.0%)
notification-settings             -4976 B  (-1.2%)    -1140 B  (-1.0%)
settings-security                 -4972 B  (-1.5%)    -1001 B  (-1.0%)
settings-discussion               -4961 B  (-1.8%)    -1673 B  (-1.9%)
earn                              -4961 B  (-1.3%)    -1691 B  (-1.5%)
email                             -4891 B  (-1.0%)    -1841 B  (-1.3%)
settings-performance              -4868 B  (-1.4%)     -847 B  (-0.8%)
jetpack-cloud-pricing             -4859 B  (-1.4%)    -1386 B  (-1.3%)
posts-custom                      -4800 B  (-1.0%)    -1572 B  (-1.1%)
plans                             -4791 B  (-0.6%)     -684 B  (-0.3%)
account                           -4769 B  (-0.9%)    -1097 B  (-0.7%)
settings                          -4689 B  (-0.8%)    -1300 B  (-0.7%)
marketplace                       -4618 B  (-0.8%)    -2126 B  (-1.2%)
checkout                          -4431 B  (-0.3%)     -126 B  (-0.0%)
plugins                           -4164 B  (-0.7%)    -3056 B  (-1.8%)
domains                           -3848 B  (-0.3%)     -324 B  (-0.1%)
site-purchases                    -3487 B  (-0.3%)      +31 B  (+0.0%)
purchases                         -3453 B  (-0.2%)     -764 B  (-0.2%)
gutenberg-editor                  -1439 B  (-0.4%)     -843 B  (-0.7%)
signup                            +1333 B  (+0.4%)     +388 B  (+0.7%)
devdocs                            -579 B  (-0.3%)     -100 B  (-0.2%)
backup                             +554 B  (+0.1%)     +195 B  (+0.1%)
hosting                            +542 B  (+0.2%)     +166 B  (+0.2%)
themes                             +508 B  (+0.1%)     +226 B  (+0.2%)
stats                              +365 B  (+0.1%)     +114 B  (+0.1%)
jetpack-cloud-partner-portal       -232 B  (-0.1%)     +180 B  (+0.3%)
reader                             +230 B  (+0.0%)     +166 B  (+0.1%)
home                               +212 B  (+0.0%)      +84 B  (+0.1%)
pages                              +166 B  (+0.0%)      +28 B  (+0.0%)
sites                              +144 B  (+0.1%)      +17 B  (+0.0%)
settings-jetpack                   +144 B  (+0.1%)      +17 B  (+0.0%)
scan                               +144 B  (+0.0%)      +17 B  (+0.0%)
preview                            +144 B  (+0.1%)      +15 B  (+0.0%)
migrate                            +144 B  (+0.1%)      +17 B  (+0.0%)
jetpack-search                     +144 B  (+0.1%)      +17 B  (+0.0%)
jetpack-cloud-settings             +144 B  (+0.1%)      +17 B  (+0.0%)
jetpack-cloud                      +144 B  (+0.1%)      +17 B  (+0.0%)
google-my-business                 +144 B  (+0.0%)     -208 B  (-0.2%)
export                             +144 B  (+0.1%)      +17 B  (+0.0%)
customize                          +144 B  (+0.1%)      +17 B  (+0.0%)
concierge                          +144 B  (+0.0%)      +17 B  (+0.0%)
activity                           +144 B  (+0.0%)      +17 B  (+0.0%)
woocommerce-installation           +138 B  (+0.1%)      +16 B  (+0.0%)
comments                           -112 B  (-0.0%)      -31 B  (-0.0%)
people                              +92 B  (+0.0%)       +3 B  (+0.0%)
import                              +92 B  (+0.0%)       +4 B  (+0.0%)
woocommerce                         -72 B  (-0.0%)      -13 B  (-0.0%)
theme                               -52 B  (-0.0%)    -1236 B  (-1.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~173624 bytes added 📈 [gzipped])

name                                                 parsed_size            gzip_size
async-load-block-editor                                +674302 B  (+34.6%)  +181267 B  (+32.9%)
async-load-design-wordpress-components-gallery          +41537 B   (+5.8%)   +12928 B   (+7.0%)
async-load-calypso-reader-site-stream                    -5435 B  (-11.6%)    -1798 B  (-11.8%)
async-load-calypso-reader-search-stream                  -5435 B   (-5.1%)    -1776 B   (-5.7%)
async-load-calypso-reader-following-manage               -5435 B   (-3.8%)    -1776 B   (-4.2%)
async-load-calypso-reader-feed-stream                    -5435 B  (-11.6%)    -1794 B  (-11.8%)
async-load-automattic-search                             -5330 B   (-6.0%)    -1764 B   (-5.9%)
async-load-signup-steps-domains                          -5259 B   (-1.4%)    -1942 B   (-1.8%)
async-load-quick-language-switcher                       -4953 B   (-3.6%)    -1827 B   (-4.1%)
async-load-signup-steps-woocommerce-install              -4861 B   (-2.9%)    -1675 B   (-3.3%)
async-load-design-playground                             -4758 B   (-0.3%)    -2089 B   (-0.5%)
async-load-design                                        -4758 B   (-0.3%)    -2089 B   (-0.5%)
async-load-design-blocks                                 -4044 B   (-0.2%)    -1856 B   (-0.3%)
async-load-calypso-blocks-editor-checkout-modal          +1328 B   (+0.1%)     +997 B   (+0.4%)
async-load-signup-steps-import                            +885 B   (+0.8%)     +319 B   (+0.9%)
async-load-calypso-blocks-jitm-templates-modal            +882 B   (+1.3%)     +295 B   (+1.3%)
async-load-signup-steps-plans                             +678 B   (+0.2%)     +740 B   (+1.0%)
async-load-calypso-components-web-preview-component       +631 B   (+0.1%)     +167 B   (+0.1%)
async-load-signup-steps-difm-design-picker                +593 B   (+0.7%)     +476 B   (+1.8%)
async-load-signup-steps-site-info-collection              +424 B   (+0.3%)     +211 B   (+0.6%)
async-load-signup-steps-clone-point                       +410 B   (+0.2%)     +184 B   (+0.3%)
async-load-signup-steps-user                              +397 B   (+0.2%)     +187 B   (+0.4%)
async-load-signup-steps-test-step                         +397 B   (+0.6%)     +180 B   (+0.8%)
async-load-signup-steps-survey                            +397 B   (+0.5%)     +182 B   (+0.7%)
async-load-signup-steps-starting-point                    +397 B   (+0.5%)     +179 B   (+0.7%)
async-load-signup-steps-site-type                         +397 B   (+0.5%)     +178 B   (+0.7%)
async-load-signup-steps-site-topic                        +397 B   (+0.4%)     +184 B   (+0.6%)
async-load-signup-steps-site-title                        +397 B   (+0.5%)     +184 B   (+0.8%)
async-load-signup-steps-site-style                        +397 B   (+0.4%)     +185 B   (+0.6%)
async-load-signup-steps-site-picker                       +397 B   (+0.3%)     +177 B   (+0.4%)
async-load-signup-steps-site-or-domain                    +397 B   (+0.5%)     +176 B   (+0.7%)
async-load-signup-steps-site-options                      +397 B   (+0.5%)     +185 B   (+0.7%)
async-load-signup-steps-site                              +397 B   (+0.4%)     +191 B   (+0.7%)
async-load-signup-steps-rewind-were-backing               +397 B   (+0.5%)     +180 B   (+0.8%)
async-load-signup-steps-rewind-migrate                    +397 B   (+0.4%)     +180 B   (+0.6%)
async-load-signup-steps-rewind-form-creds                 +397 B   (+0.4%)     +177 B   (+0.5%)
async-load-signup-steps-rebrand-cities-welcome            +397 B   (+0.5%)     +183 B   (+0.8%)
async-load-signup-steps-reader-landing                    +397 B   (+0.5%)     +180 B   (+0.8%)
async-load-signup-steps-plans-atomic-store                +397 B   (+0.2%)     +188 B   (+0.3%)
async-load-signup-steps-passwordless                      +397 B   (+0.5%)     +183 B   (+0.7%)
async-load-signup-steps-p2-site                           +397 B   (+0.4%)     +191 B   (+0.6%)
async-load-signup-steps-p2-details                        +397 B   (+0.5%)     +184 B   (+0.8%)
async-load-signup-steps-intent                            +397 B   (+0.5%)     +179 B   (+0.7%)
async-load-signup-steps-import-url-onboarding             +397 B   (+0.3%)     +180 B   (+0.5%)
async-load-signup-steps-import-url                        +397 B   (+0.4%)     +180 B   (+0.6%)
async-load-signup-steps-import-preview                    +397 B   (+0.4%)     +180 B   (+0.6%)
async-load-signup-steps-import-from                       +397 B   (+0.5%)     +181 B   (+0.8%)
async-load-signup-steps-emails                            +397 B   (+0.5%)     +172 B   (+0.6%)
async-load-signup-steps-creds-permission                  +397 B   (+0.4%)     +172 B   (+0.6%)
async-load-signup-steps-creds-confirm                     +397 B   (+0.4%)     +172 B   (+0.6%)
async-load-signup-steps-creds-complete                    +397 B   (+0.5%)     +179 B   (+0.8%)
async-load-signup-steps-clone-start                       +397 B   (+0.5%)     +182 B   (+0.7%)
async-load-signup-steps-clone-ready                       +397 B   (+0.4%)     +185 B   (+0.6%)
async-load-signup-steps-clone-jetpack                     +397 B   (+0.5%)     +184 B   (+0.8%)
async-load-signup-steps-clone-destination                 +397 B   (+0.5%)     +189 B   (+0.7%)
async-load-signup-steps-clone-credentials                 +397 B   (+0.3%)     +170 B   (+0.4%)
async-load-signup-steps-clone-cloning                     +397 B   (+0.5%)     +187 B   (+0.8%)
async-load-signup-steps-about                             +397 B   (+0.3%)     +191 B   (+0.5%)
async-load-calypso-blocks-inline-help-popover             -295 B   (-0.1%)      -14 B   (-0.0%)
async-load-signup-steps-theme-selection                   +294 B   (+0.2%)     +467 B   (+1.1%)
async-load-calypso-post-editor-media-modal                +267 B   (+0.0%)     +403 B   (+0.1%)
async-load-calypso-post-editor-editor-media-modal         +208 B   (+0.0%)     +407 B   (+0.1%)
async-load-signup-steps-design-picker                     +148 B   (+0.1%)     +112 B   (+0.3%)
async-load-calypso-my-sites-sidebar-unified               +136 B   (+0.1%)     +391 B   (+1.3%)
async-load-calypso-my-sites-sidebar                       +136 B   (+0.1%)     +391 B   (+0.6%)
async-load-calypso-components-jetpack-sidebar             +136 B   (+0.3%)     +391 B   (+2.4%)
async-load-store-app-store-stats-referrers                 -92 B   (-0.1%)     -915 B   (-3.6%)
async-load-store-app-store-stats                           -92 B   (-0.1%)     -849 B   (-1.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[scinos]

Current status: I fixed all problems (afaik) related to missing peer dependencies, duplicated packages, compilation errors, etc. I have not investigated the E2E errors or verified the functionality of the site.

[noahtallen]

There was a conflict with the react-native update, so I rebased. There is one remaining peer dependency issue now, also related to react native.

I looked into it again, and we are so close to being able to remove react native everywhere. None of the updated wordpress packages seem to require react-native any more, but some of our transitive dependencies still rely on outdated versions of @wordpress/url (Namely, @types/wordpress__data-controls)

edit: this DT PR should fix the transitive dependency: DefinitelyTyped/DefinitelyTyped#57085

[scinos]

There are two pending issues:

E2E errors

They are real and easy to reproduce. Just go to /new and try changing the language. I suspect it may be related to WordPress/gutenberg#34539. WordPress/gutenberg#35282 sounds relevant too. @Automattic/team-calypso-frameworks, could you help with this issue?

Bundle size

The increase in entry-gutenboarding and async-load-block-editor is huge. However, when using CONCATENATE_MODULES=false yarn analyze-bundles to find where the difference comes from, both bundles have the same-ish size then trunk, so probably I'm not looking at the right place. @sgomes, could you help with this?

[jsnajdr]

I investigated the bundle size increase for the entry-gutenboarding chunk, and for the async-load-block-editor chunk, with yarn analyze-bundles, limiting entrypoints and sections with ENTRY_LIMIT and SECTION_LIMIT.

The entry-gutenboarding bundle increase looks OK and unavoidable. I don't see any duplicated packages, it's just @wordpress/components and @wordpress/block-editor are now bigger, by ~130kB. Probably because there are more features and more components.

The async-load-block-editor increase is much bigger, ~680kB. And there are problems with the @automattic/isolated-block-editor. Look at the treechart:

isolated-block-editor has its own copy of block-editor and of components, and the block-editor has yet another copy of components. This should be all deduplicated and hoisted to the top-level node_modules directory.

[scinos]

Thanks for the investigation.

Maybe we should do #57825 at the same time to avoid bloating isolated-block-editor 🤔

[noahtallen]

It's async loaded and it's a rarely-used experimental feature:

wp-calypso/client/blocks/comments/form.jsx

Lines 179 to 185 in f2e6f88

	const formTextarea = isEnabled( 'reader/gutenberg-for-comments' ) ? (
	<AsyncLoad
	require="./block-editor"
	onChange={ this.handleTextChange }
	siteId={ this.props.post.site_ID }
	/>
	) : (

So it theoretically doesn't have a big impact on production. Either way, it'd be easy to do that upgrade at the same time

[sgomes]

@scinos Sorry I wasn't able to pitch in earlier, but it looks like @jsnajdr already performed an investigation in my stead. Thank you @jsnajdr!

I need to add that the approach that @wordpress/components and @wordpress/block-editor are taking is not sustainable. They can't keep increasing in size time after time without modularisation being significantly improved, or every consumer will keep getting larger. From version 15 to version 19, @wordpress/components alone has grown from 416.5KB gzipped to 439.5KB gzipped. That's over 5% over the course of just three months.

There is a lot potential for these packages to have a much smaller impact in their consumers, if they're re-organised to have less interdependent code, or perhaps split out further into smaller packages.

[scinos]

FWIW, I listed all outdated @wordpress packages left in our dependency tree after applying this branch and where they come from:

newspack-components@npm:1.6.1
    @wordpress/base-styles@npm:3.6.0
    @wordpress/components@npm:12.0.8
        @wordpress/a11y@npm:2.15.3
            @wordpress/dom-ready@npm:2.13.2
            @wordpress/i18n@npm:3.20.0
        @wordpress/compose@npm:3.25.3
            @wordpress/deprecated@npm:2.12.3
                @wordpress/hooks@npm:2.12.3
            @wordpress/dom@npm:2.18.0
            @wordpress/element@npm:2.20.3
                @wordpress/escape-html@npm:1.12.2
            @wordpress/is-shallow-equal@npm:3.1.3
            @wordpress/keycodes@npm:2.19.3
            @wordpress/priority-queue@npm:1.11.2
        @wordpress/date@npm:3.15.1
        @wordpress/deprecated@npm:2.12.3
        @wordpress/dom@npm:2.18.0
        @wordpress/element@npm:2.20.3
        @wordpress/hooks@npm:2.12.3
        @wordpress/i18n@npm:3.20.0
                @wordpress/hooks@npm:2.12.3
        @wordpress/icons@npm:2.10.3
            @wordpress/element@npm:2.20.3
            @wordpress/element@npm:3.2.0
            @wordpress/primitives@npm:1.12.3
        @wordpress/is-shallow-equal@npm:3.1.3
        @wordpress/keycodes@npm:2.19.3
        @wordpress/primitives@npm:1.12.3
            @wordpress/element@npm:2.20.3
        @wordpress/rich-text@npm:3.25.3
            @wordpress/compose@npm:3.25.3
            @wordpress/data@npm:4.27.3
                @wordpress/compose@npm:3.25.3
                @wordpress/deprecated@npm:2.12.3
                @wordpress/element@npm:2.20.3
                @wordpress/is-shallow-equal@npm:3.1.3
                @wordpress/priority-queue@npm:1.11.2
                @wordpress/redux-routine@npm:3.14.2
            @wordpress/dom@npm:2.18.0
            @wordpress/element@npm:2.20.3
            @wordpress/escape-html@npm:1.12.2
            @wordpress/is-shallow-equal@npm:3.1.3
            @wordpress/keycodes@npm:2.19.3
                @wordpress/i18n@npm:3.20.0
        @wordpress/warning@npm:1.4.2
    @wordpress/element@npm:2.20.3
    @wordpress/i18n@npm:3.20.0
    @wordpress/icons@npm:4.1.0
        @wordpress/primitives@npm:2.2.0
            @wordpress/element@npm:3.2.0

@automattic/isolated-block-editor@npm:2.6.0
    @wordpress/block-editor@npm:7.0.4

@automattic/newspack-blocks@npm:1.37.1
    @wordpress/icons@npm:5.0.2
    
@types/wordpress__data-controls@npm:1.0.5
    @wordpress/api-fetch@npm:3.23.1
        @wordpress/i18n@npm:3.20.0
        @wordpress/url@npm:2.22.2

@types/wordpress__blocks@npm:6.4.12
    @wordpress/element@npm:2.20.3

@types/wordpress__media-utils@npm:0.2.4
    @wordpress/element@npm:2.20.3

@types/wordpress__block-editor@npm:6.0.4
    @wordpress/element@npm:3.2.0

@types/wordpress__components
    @wordpress/element@npm:3.2.0

@types/wordpress__compose
    @wordpress/element@npm:3.2.0

@types/wordpress__editor
    @wordpress/element@npm:3.2.0

@types/wordpress__plugins
    @wordpress/element@npm:3.2.0

wp-e2e-tests@workspace:test/e2e
    @wordpress/i18n@npm:3.20.0

Once we update to a version of newspack-components that includes Automattic/newspack-plugin#1135, we'll remove a lot of outdated deps.

[noahtallen]

Once we update to a version of newspack-components that includes Automattic/newspack-plugin#1135, we'll remove a lot of outdated deps.

Definitely. Though, one challenge is keeping all of the other consumers up to date as well. For example, I believe we will still be on one version newer WordPress packages compared to newspack by the time we can get that package updated.

[noahtallen]

The current error is that e2e tests can't change the language in the account page. It works for me in calypso.localhost, so unsure what the exact problem is. I am seeing this warning on the account page:

Warning: Cannot update a component (`Connect(MomentProvider)`) while rendering a different component (`Connect(Localized(WithLocalizedMoment(ProtectForm(Account))))`). To locate the bad setState() call inside `Connect(Localized(WithLocalizedMoment(ProtectForm(Account))))`, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
nextEnter@app:///../node_modules/page/page.js:713:9

The screenshot in TeamCity just shows a blank screen. I guess that could mean that the page reload isn't finishing?

[scinos]

The E2E error is real, I can reproduce it in calypso.live

More details in #57217 (comment)

[jsnajdr]

The crash in /new when selecting language can be resolved by mounting the <ShortcutProvider> near the <BlockEditorProvider>. The useShortcut hook relies on getting the shortcut set from a context, but without the provider, it's null. After 0e3a604 it started working for me.

[jsnajdr]

Warning: Cannot update a component (Connect(MomentProvider)) while rendering a different component

This one, in the Me > Account Settings screen, exists even before this PR. It's caused by the requestGeoLocation function dispatching an action although it's used as a selector. We'll need to migrate away from the http-data library to fix that.

[jsnajdr]

Warning: Cannot update a component (Connect(MomentProvider)) while rendering a different component

This warning is being fixed in #58236 by migrating away from http-data, to React Query.

[noahtallen]

Since gutenboarding (IIRC) is strictly typed, it needed a type definition for @wordpress/keyboard-shortcuts. (We don't have one yet on DT -- though maybe we could add a declaration file in Gutenberg itself). So I added a types.d.ts file in the top-level of gutenboarding and placed it there. (Is there a better place for it?)

I also took the opportunity to resolve a TODO comment I had left during a previous wp monorepo upgrade, which said to move a .scss import back into the TS file from the SCSS file.

[noahtallen]

I think this is good to go! The ETK changes are very minimal. Smoke testing gutenboarding/calypso, everything seems okay.