-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Improve post-renewal copy and fix "learn more" link #54993
Checkout: Improve post-renewal copy and fix "learn more" link #54993
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-11604 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~6 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~35 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~46 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I updated the title of this PR to I'd also suggest maybe including information in the PR description about what was fixed about the "learn more" link. Currently it explains that the text is being changed, but it doesn't mention anything about the link (apart from a reference to "link target" without much context). It could also be that nothing was broken about the "learn more" link after all and I mistakenly kept that wording in the title, in which case we can remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client/my-sites/checkout/composite-checkout/hooks/use-create-payment-complete-callback.tsx
Outdated
Show resolved
Hide resolved
client/my-sites/checkout/composite-checkout/hooks/use-create-payment-complete-callback.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. The diff looks good to me now.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6301359 Thank you @chrisfromthelc for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This pull request addresses post-renewal notice copy for renewals that are set to auto-renew going forward. It replaces the text
{Plan} has been renewed and will now auto renew in the future. Learn more.
(old link target) pointing to the main Manage Purchases support doc, with'Success! You renewed {productName} for {duration}, and we sent your receipt to {email}. Learn more about renewals.
(new link target) pointing to the specific renewals section in the Manage Purchases support doc.Old version:

New version:

For plans that cannot autorenew due to the payment type (WordPress.com credits, non-US transactions, etc.), they will be shown the text without the autorenewal link:
'Success! You renewed {productName} for {duration}, and we sent your receipt to {email}.
.Testing instructions
Renew any plan using a test credit card number.
The message should display as below, along with the link that should lead to https://wordpress.com/support/manage-purchases/#automatic-renewal.
Fixes #324