Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Improve post-renewal copy and fix "learn more" link #54993

Merged
merged 5 commits into from
Jul 29, 2021

Conversation

chrisfromthelc
Copy link
Contributor

@chrisfromthelc chrisfromthelc commented Jul 28, 2021

Changes proposed in this Pull Request

This pull request addresses post-renewal notice copy for renewals that are set to auto-renew going forward. It replaces the text {Plan} has been renewed and will now auto renew in the future. Learn more. (old link target) pointing to the main Manage Purchases support doc, with 'Success! You renewed {productName} for {duration}, and we sent your receipt to {email}. Learn more about renewals. (new link target) pointing to the specific renewals section in the Manage Purchases support doc.

Old version:
Screen Shot 2021-07-28 at 3 39 45 PM

New version:
Screen Shot 2021-07-28 at 3 38 07 PM

For plans that cannot autorenew due to the payment type (WordPress.com credits, non-US transactions, etc.), they will be shown the text without the autorenewal link: 'Success! You renewed {productName} for {duration}, and we sent your receipt to {email}..

Testing instructions

Renew any plan using a test credit card number.

The message should display as below, along with the link that should lead to https://wordpress.com/support/manage-purchases/#automatic-renewal.

Screen Shot 2021-07-28 at 3 38 07 PM

Fixes #324

@chrisfromthelc chrisfromthelc added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Post Checkout Good First Issue Small, contained issues. Microcopy Issues and exploration for updating UI copy labels Jul 28, 2021
@chrisfromthelc chrisfromthelc self-assigned this Jul 28, 2021
@chrisfromthelc chrisfromthelc requested a review from a team as a code owner July 28, 2021 22:45
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 28, 2021
@github-actions
Copy link

github-actions bot commented Jul 28, 2021

@matticbot
Copy link
Contributor

matticbot commented Jul 28, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-domains-landing        +23 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~35 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
checkout                       +132 B  (+0.0%)      -18 B  (-0.0%)
woocommerce-installation        +23 B  (+0.0%)       +3 B  (+0.0%)
themes                          +23 B  (+0.0%)       -3 B  (-0.0%)
theme                           +23 B  (+0.0%)       -3 B  (-0.0%)
site-purchases                  +23 B  (+0.0%)       -1 B  (-0.0%)
settings-security               +23 B  (+0.0%)       -3 B  (-0.0%)
settings-performance            +23 B  (+0.0%)       -3 B  (-0.0%)
settings-jetpack                +23 B  (+0.0%)       -3 B  (-0.0%)
settings                        +23 B  (+0.0%)       -1 B  (-0.0%)
security                        +23 B  (+0.0%)       -2 B  (-0.0%)
scan                            +23 B  (+0.0%)       -1 B  (-0.0%)
purchases                       +23 B  (+0.0%)       -1 B  (-0.0%)
purchase-product                +23 B  (+0.0%)       -2 B  (-0.0%)
plugins                         +23 B  (+0.0%)       -3 B  (-0.0%)
plans                           +23 B  (+0.0%)       -3 B  (-0.0%)
marketplace                     +23 B  (+0.0%)       -1 B  (-0.0%)
marketing                       +23 B  (+0.0%)       -3 B  (-0.0%)
jetpack-search                  +23 B  (+0.0%)       -1 B  (-0.0%)
jetpack-connect                 +23 B  (+0.0%)       -3 B  (-0.0%)
jetpack-cloud-settings          +23 B  (+0.0%)       -3 B  (-0.0%)
jetpack-cloud-pricing           +23 B  (+0.0%)       -3 B  (-0.0%)
incoming-redirect               +23 B  (+0.3%)       -1 B  (-0.0%)
help                            +23 B  (+0.0%)       +0 B
google-my-business              +23 B  (+0.0%)       -3 B  (-0.0%)
export                          +23 B  (+0.0%)       -4 B  (-0.0%)
email                           +23 B  (+0.0%)       -3 B  (-0.0%)
domains                         +23 B  (+0.0%)       -1 B  (-0.0%)
concierge                       +23 B  (+0.0%)       -1 B  (-0.0%)
backup                          +23 B  (+0.0%)       -1 B  (-0.0%)
activity                        +23 B  (+0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~46 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-blocks-editor-checkout-modal       +132 B  (+0.0%)      -18 B  (-0.0%)
async-load-signup-steps-user                           +23 B  (+0.0%)       -3 B  (-0.0%)
async-load-signup-steps-rewind-form-creds              +23 B  (+0.0%)       -1 B  (-0.0%)
async-load-signup-steps-plans-atomic-store             +23 B  (+0.0%)       -2 B  (-0.0%)
async-load-signup-steps-plans                          +23 B  (+0.0%)       -2 B  (-0.0%)
async-load-signup-steps-emails                         +23 B  (+0.1%)       -3 B  (-0.0%)
async-load-signup-steps-domains                        +23 B  (+0.0%)       -1 B  (-0.0%)
async-load-signup-steps-creds-permission               +23 B  (+0.1%)       -3 B  (-0.0%)
async-load-signup-steps-creds-confirm                  +23 B  (+0.1%)       -2 B  (-0.0%)
async-load-signup-steps-clone-credentials              +23 B  (+0.0%)       -3 B  (-0.0%)
async-load-design-blocks                               +23 B  (+0.0%)       -1 B  (-0.0%)
async-load-calypso-my-sites-sidebar-unified            +23 B  (+0.0%)       -3 B  (-0.0%)
async-load-calypso-my-sites-sidebar                    +23 B  (+0.0%)       -3 B  (-0.0%)
async-load-calypso-layout-nps-survey-notice            +23 B  (+0.1%)       +0 B
async-load-calypso-components-jetpack-sidebar          +23 B  (+0.1%)       -4 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig changed the title Fix/post checkout copy and fix learn more link Checkout: Improve post-renewal copy and fix "learn more" link Jul 29, 2021
@sirbrillig
Copy link
Member

I updated the title of this PR to Checkout: Improve post-renewal copy and fix "learn more" link because I felt that Fix/post checkout copy and fix learn more link wasn't very clear. Feel free to change it again if you come up with something better!

I'd also suggest maybe including information in the PR description about what was fixed about the "learn more" link. Currently it explains that the text is being changed, but it doesn't mention anything about the link (apart from a reference to "link target" without much context). It could also be that nothing was broken about the "learn more" link after all and I mistakenly kept that wording in the title, in which case we can remove it.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as described!

success-message

I left one comment which I think needs to be taken care of but otherwise 👍

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. The diff looks good to me now.

@chrisfromthelc chrisfromthelc merged commit 3c8d13f into trunk Jul 29, 2021
@chrisfromthelc chrisfromthelc deleted the fix/post-checkout-copy-and-fix-learn-more-link branch July 29, 2021 17:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2021
@a8ci18n
Copy link

a8ci18n commented Jul 29, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6301359

Thank you @chrisfromthelc for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Aug 5, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Small, contained issues. Microcopy Issues and exploration for updating UI copy Post Checkout [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Allow dropping on featured image
4 participants