-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E fixes for Gutenberg v10.5.x #52183
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
dab65be
to
c660a06
Compare
6d65d2d
to
1181077
Compare
1181077
to
65852c3
Compare
Mobile viewport GB E2E failures seem flaky. They are passing for me locally:
|
1d3ca74
to
a401f5d
Compare
Closed without merging the fixes yesterday 🤦🏻 ... will run the tests for 10.5.4 and merge this one. |
Fix selectors for the layout-grid block and inner block selections Remove deprecatd deprecation selector Fix image file upload The image block is now initially not selected (updated in WordPress/gutenberg@22bde90). It has to be though, if we want to sendKeys to the file input. That's why we're clicking the block title here. Make sure image upload is based on a proper block id
a401f5d
to
c4f99bb
Compare
Rebased. |
This reverts commit ef0680e.
@@ -78,8 +78,11 @@ class LayoutGridBlockComponent extends GutenbergBlockComponent { | |||
By.css( `button.editor-block-list-item-${ blockClass.blockName.replace( '/', '-' ) }` ) | |||
); | |||
|
|||
// @TODO Remove the `deprecatedInsertedBlockLocator` once we get 10.5.0 in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to revert this commit, it looks like some blocks are still using this "deprecated" locator.
Tracking issue: #51997.