Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E fixes for Gutenberg v10.5.x #52183

Merged
merged 5 commits into from
May 5, 2021
Merged

Conversation

fullofcaffeine
Copy link
Contributor

Tracking issue: #51997.

@fullofcaffeine fullofcaffeine added DO NOT MERGE [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Apr 21, 2021
@github-actions
Copy link

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fullofcaffeine fullofcaffeine force-pushed the test/gutenberg-10.5.0-upgrade branch from dab65be to c660a06 Compare April 28, 2021 23:23
@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.0 RC1 Gutenberg: Run E2E suite against v10.5.0 Apr 29, 2021
@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.0 Gutenberg: Run E2E suite against v10.5.2 Apr 29, 2021
@fullofcaffeine fullofcaffeine force-pushed the test/gutenberg-10.5.0-upgrade branch from 6d65d2d to 1181077 Compare April 29, 2021 15:54
@WunderBart WunderBart force-pushed the test/gutenberg-10.5.0-upgrade branch from 1181077 to 65852c3 Compare April 29, 2021 17:42
@fullofcaffeine
Copy link
Contributor Author

Mobile viewport GB E2E failures seem flaky. They are passing for me locally:

HEADLESS=1 GUTENBERG_EDGE=true BROWSERSIZE=mobile ./node_modules/.bin/mocha specs-gutenberg/wp-calypso-gutenberg-page-editor-spec.js


  [WPCOM] Calypso Gutenberg Editor: Pages (mobile)
    Public Pages: @parallel
Logging in as e2eflowtestinggutenbergsimpleedge
      ✓ Can log in (33851ms)
      ✓ Can enter page title, content and image (14959ms)
      ✓ Can launch page preview (4119ms)
      ✓ Can see correct page title in preview (1960ms)
      ✓ Can see correct page content in preview (60ms)
      ✓ Can see the image uploaded in the preview (48ms)
      ✓ Can close page preview (284ms)
      ✓ Can publish and preview published content (4706ms)
      ✓ Can see correct page title
      ✓ Can see correct page content
      ✓ Can see the image uploaded displayed
    Private Pages: @parallel
Logging in as e2eflowtestinggutenbergsimpleedge
      ✓ Can log in (29664ms)
      ✓ Can enter page title and content (7791ms)
      ✓ Can set visibility to private which immediately publishes it (4938ms)
      ✓ Can view content (2664ms)
      ✓ Can view page title as logged in user
      ✓ Can view page content as logged in user
      ✓ Can't view page title or content as non-logged in user (698ms)
    Password Protected Pages: @parallel
      Publish a Password Protected Page
Logging in as e2eflowtestinggutenbergsimpleedge
        ✓ Can log in (29533ms)
        ✓ Can enter page title and content and set to password protected (11778ms)
        ✓ Can publish and view content (6298ms)
        ✓ As a logged in user, With no password entered, Can view page title
        ✓ Can see password field
        ✓ Can't see content when no password is entered
        ✓ With incorrect password entered, Enter incorrect password (1044ms)
        ✓ Can view page title
        ✓ Can see password field
        ✓ Can't see content when incorrect password is entered
        ✓ With correct password entered, Enter correct password (850ms)
        ✓ Can view page title
        ✓ Can't see password field (2029ms)
        ✓ Can see page content
        ✓ As a non-logged in user, Clear cookies (log out) (382ms)
        ✓ With no password entered, Can view page title
        ✓ Can see password field
        ✓ Can't see content when no password is entered
        ✓ With incorrect password entered, Enter incorrect password (718ms)
        ✓ Can view page title
        ✓ Can see password field
        ✓ Can't see content when incorrect password is entered
        ✓ With correct password entered, Enter correct password (754ms)
        ✓ Can view page title
        ✓ Can't see password field (2016ms)
        ✓ Can see page content
    Insert a payment button into a page: @parallel
Logging in as e2eflowtestinggutenbergsimpleedge
      ✓ Can log in (29758ms)
      ✓ Can insert the payment button (8503ms)
      ✓ Can publish and view content (26928ms)
      ✓ Can see the payment button in our published page (5717ms)
      ✓ The payment button in our published page opens a new Paypal window for payment (6067ms)


  49 passing (4m)

@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.2 Gutenberg: Run E2E suite against v10.5.3 May 4, 2021
@fullofcaffeine fullofcaffeine force-pushed the test/gutenberg-10.5.0-upgrade branch from 1d3ca74 to a401f5d Compare May 4, 2021 18:50
@fullofcaffeine fullofcaffeine reopened this May 5, 2021
@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.3 Gutenberg: Run E2E suite against v10.5.4 May 5, 2021
@fullofcaffeine
Copy link
Contributor Author

Closed without merging the fixes yesterday 🤦🏻 ... will run the tests for 10.5.4 and merge this one.

Fix selectors for the layout-grid block and inner block selections

Remove deprecatd deprecation selector

Fix image file upload
The image block is now initially not selected (updated in WordPress/gutenberg@22bde90). It has to be though, if we want to sendKeys to the file input. That's why we're clicking the block title here.

Make sure image upload is based on a proper block id
@fullofcaffeine fullofcaffeine force-pushed the test/gutenberg-10.5.0-upgrade branch from a401f5d to c4f99bb Compare May 5, 2021 16:40
@fullofcaffeine
Copy link
Contributor Author

Rebased.

@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.4 Gutenberg: Run E2E suite against v10.5.4 + fixes May 5, 2021
@@ -78,8 +78,11 @@ class LayoutGridBlockComponent extends GutenbergBlockComponent {
By.css( `button.editor-block-list-item-${ blockClass.blockName.replace( '/', '-' ) }` )
);

// @TODO Remove the `deprecatedInsertedBlockLocator` once we get 10.5.0 in production.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to revert this commit, it looks like some blocks are still using this "deprecated" locator.

@fullofcaffeine fullofcaffeine changed the title Gutenberg: Run E2E suite against v10.5.4 + fixes E2E fixes for Gutenberg v10.5.x May 5, 2021
@fullofcaffeine fullofcaffeine merged commit a56e73a into trunk May 5, 2021
@fullofcaffeine fullofcaffeine deleted the test/gutenberg-10.5.0-upgrade branch May 5, 2021 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants