Build: Install pre-commit githook on make run
#504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehg
added
[Status] Needs Review
| @@ -44,7 +44,7 @@ export NODE_PATH := server:shared:$(THIS_DIR) | |||
| install: node_modules | |||
|
|
|||
| # Simply running `make run` will spawn the Node.js server instance. | |||
| run: install build | |||
| run: githooks-commit install build | |||
There was a problem hiding this comment.
I think this should just be githooks. We have both pre-commit and pre-push githooks, and githooks should install both of them.
There was a problem hiding this comment.
Given how slow our test suite is, I opted for just the pre-commit. I suppose we could require the pre-push as well —maybe it'll force us to improve the tests…
There was a problem hiding this comment.
ok, fair enough... then let's run with this.
rralian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
👍 |
The rationale for this is that we'd like more exposure for the GPLv2 contribution notice. Installing them on `make run` seems like a good way to do this. The way that `bin/pre-commit` is set up now, this will also force the running of i18nlint and eslint checks. Which is a Good Thing in any case. Of course, these checks can be bypassed using `git commit --no-verify`
ehg
force-pushed
the
add/force-precommit-on-run
branch
from
d0abe88
to
5bafcd4
Compare
ehg
added a commit
that referenced
this pull request
Nov 23, 2015
Build: Install pre-commit githook on `make run`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this is that we'd like more exposure for the GPLv2 contribution notice. Installing them on
make runseems like a good way to do this.The way that
bin/pre-commitis set up now, this will also force the running of i18nlint and eslint checks. Which is a Good Thing in any case.Of course, these checks can be bypassed using
git commit --no-verifyTo test:
rm .git/hooks/pre-commitmake run, check that the.git/hooks/pre-commitsymlink is reinstated/cc @rralian