Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracking the 'core/block-editor' events #50243

Merged

Conversation

fullofcaffeine
Copy link
Contributor

Changes proposed in this Pull Request

Fix tracking the 'core/block-editor' events. Since WordPress/gutenberg#28775 namespace is not always a string.

Testing instructions

This has been tested by @WunderBart locally. After merging this, the remaining tests here #50108 should pass.

Related to #50108. Context: p1613662487260800-slack-C02A41GCS.

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@fullofcaffeine
Copy link
Contributor Author

Corresponding diff: D57303-code.

@fullofcaffeine fullofcaffeine force-pushed the fix/wpcom-block-editor-tracking-namespace-arg-shape-bug branch from 37a592b to c9417fc Compare February 19, 2021 00:54
@fullofcaffeine
Copy link
Contributor Author

fullofcaffeine commented Feb 19, 2021

D57303-code has been landed (thanks for reviewing and approving @Addison-Stavlo!), going to merge this now.

@fullofcaffeine fullofcaffeine merged commit 21d2a25 into trunk Feb 19, 2021
@fullofcaffeine fullofcaffeine deleted the fix/wpcom-block-editor-tracking-namespace-arg-shape-bug branch February 19, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants