Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Remove unused TransactionFlow and dependencies #48495

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

sirbrillig
Copy link
Member

Changes proposed in this Pull Request

Since #48152 was merged, TransactionFlow is no longer used by anything in calypso. This PR removes it. There are still some parts of used code in lib/store-transactions but that will be removed in other PRs as those functions are moved elsewhere.

Testing instructions

Just make sure that the deleted code is no longer used anymore.

@matticbot
Copy link
Contributor

@sirbrillig sirbrillig self-assigned this Dec 18, 2020
@sirbrillig sirbrillig requested a review from a team December 18, 2020 16:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 18, 2020
@sirbrillig sirbrillig added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Dec 18, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~6215 bytes removed 📉 [gzipped])

name            parsed_size           gzip_size
woocommerce         -7051 B  (-0.3%)    -1533 B  (-0.3%)
site-purchases      -7051 B  (-0.6%)    -1591 B  (-0.5%)
purchases           -7051 B  (-0.5%)    -1468 B  (-0.4%)
checkout            -7051 B  (-0.5%)    -1623 B  (-0.5%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1655 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-blocks-editor-checkout-modal      -7051 B  (-0.6%)    -1655 B  (-0.6%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@nbloomf
Copy link
Contributor

nbloomf commented Dec 18, 2020

Looks good!

@sirbrillig sirbrillig added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 18, 2020
@sirbrillig sirbrillig mentioned this pull request Dec 24, 2020
@sirbrillig sirbrillig merged commit 537c70c into trunk Jan 4, 2021
@sirbrillig sirbrillig deleted the remove/transaction-flow branch January 4, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Estimate] 1 [Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants