Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout: Fix import of createTransactionEndpointCartFromLineItems for PayPal #48431

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Checkout: Fix import of createTransactionEndpointCartFromLineItems for PayPal #48431

merged 2 commits into from
Dec 16, 2020

Conversation

sirbrillig
Copy link
Member

@sirbrillig sirbrillig commented Dec 16, 2020 •
edited
Loading

Changes proposed in this Pull Request

Fixes a regression added by #48069 where we moved createTransactionEndpointCartFromLineItems but failed to update all the imports.

Same as #48427 but for PayPal

Testing instructions

  • Test a paypal purchase and be sure you're redirected to PayPal and there's no errors. No need to actually complete the purchase. If the redirect works, it should work.

@sirbrillig sirbrillig requested a review from a team as a code owner December 16, 2020 21:41
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/paypal-express-fix-import-translate

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 16, 2020
@sirbrillig sirbrillig added [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended labels Dec 16, 2020
@matticbot
Copy link
Contributor

matticbot commented Dec 16, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~30 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
checkout       -170 B  (-0.0%)      -30 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~29 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-blocks-editor-checkout-modal       -170 B  (-0.0%)      -29 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig merged commit 189cd02 into trunk Dec 16, 2020
@sirbrillig sirbrillig deleted the fix/paypal-express-fix-import-translate branch December 16, 2020 22:02
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 16, 2020
sarayourfriend pushed a commit that referenced this pull request Dec 23, 2020
@sirbrillig @sarayourfriend
Checkout: Fix import of createTransactionEndpointCartFromLineItems fo…
4c831b3 
…r PayPal (#48431)

* Fix import of createTransactionEndpointCartFromLineItems

* No need to duplicate import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pottedmeat pottedmeat pottedmeat approved these changes

Assignees
No one assigned
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirbrillig @matticbot @pottedmeat