Checkout: Stop memoizing domainDetails for existingCardProcessor

[sirbrillig]

Changes proposed in this Pull Request

Make sure domain details for existing card purchases is always up-to-date. Otherwise if the contact details are modified and the cart doesn't change, the domain details submitted to the transactions endpoint will be out-of-date, resulting in weird errors about missing data when there's clearly no data missing.

The underlying issue is that getDomainDetails is not a pure function. It fetches data from a @wordpress/data store and so it has a hidden dependency that isn't in the dependencies for useMemo.

This was a regression added by #48069

Testing instructions

• Purchase a .ca TLD using an existing card.
• Make sure that the purchase completes with no errors.

[matticbot]

Test live: https://calypso.live/?branch=fix/domain-details-existing-card-proc

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~10 bytes removed 📉 [gzipped])

name      parsed_size           gzip_size
checkout        -31 B  (-0.0%)      -10 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-blocks-editor-checkout-modal        -31 B  (-0.0%)       -8 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.