Checkout: extract calling payment processor and handling response to useProcessPayment hook #48283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
added
the
[Feature] Checkout
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~91 bytes added 📈 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~48 bytes added 📈 [gzipped]) React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
matticbot
added
the
[Status] Needs Review
sirbrillig
force-pushed
the
add/use-process-payment
branch
from
6c398c7 to
c26c402
Compare
sirbrillig
force-pushed
the
add/use-process-payment
branch
from
c26c402 to
08c0d4e
Compare
|
Rebased after #48385 |
nbloomf
approved these changes
Dec 16, 2020
nbloomf
added
[Status] Ready to Merge
and removed
[Status] Needs Review
sarayourfriend
pushed a commit
that referenced
this pull request
Dec 23, 2020
…useProcessPayment hook (#48283) * Clarify manual transaction processing in composite-checkout README * Separate payment processor response handling into own function * Export useCreatePaymentProcessorOnClick from composite-checkout * Add missing useCreatePaymentProcessorOnClick * Rethrow PaymentProcessorResponse error * Allow payment complete callback to include isComingFromUpsell * Add withPaymentCompleteCallback HOC * Clean up PaymentCompleteCallback type a bit * Remove withPaymentCompleteCallback and shouldHideUpsellNudges * Fix useCreatePaymentProcessorOnClick import * Rename onClick creator to useProcessPayment * Throw if using useStripe outside StripeHookProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
When a payment method's
submitButtonprop is rendered by@automattic/composite-checkout, it is provided with anonClickprop that can be used to call a payment processor function and handle the response. As consumers of the package (like the one-click upsell; see #48152) might want to implement their own submit button, we should expose that automated process in its own hook.This PR creates a hook called
useProcessPaymentthat does just that and adds it to the@automattic/composite-checkoutpackage.This PR shouldn't have any user-facing effect on checkout.
Testing instructions