Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach a VCS config to the placeholder build #47369

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Nov 12, 2020

Update to #47361

I forgot to attach a Git repo to the placeholder build. Without it, it can't run for branches, so I can't run #47368 to verify it works 🤦

Testing instructions

  • Verify the TeamCity build for this branch doesn't throw any syntax error when applying the build plan (open Run unit tests, look for "Finalize build settings" in the log and verify there are no errors)

@matticbot
Copy link
Contributor

@scinos scinos self-assigned this Nov 12, 2020
@scinos scinos added TeamCity Changes in TeamCity configuration Expedited Review labels Nov 12, 2020
@scinos scinos requested a review from a team November 12, 2020 13:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 12, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻LGTM

@scinos scinos merged commit baa21c4 into master Nov 12, 2020
@scinos scinos deleted the ci/base-desktop-build-2 branch November 12, 2020 15:06
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expedited Review TeamCity Changes in TeamCity configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants