Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color scheme ocean #47333

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Add color scheme ocean #47333

merged 2 commits into from
Nov 16, 2020

Conversation

mreishus
Copy link
Contributor

One part of #47036

Changes proposed in this Pull Request

  • Add ocean color scheme

Testing instructions

  • Visit /me/account
  • Choose ocean and save
  • Try with flag nav unification on and off

To see the wp-admin color scheme, create an atomic site, then visit /wp-admin/profile.php, choose color scheme and save.

Calypso (Flag off):
2020-11-11_11-35

Calypso (Flag on):
2020-11-11_11-36

Wp-Admin:
2020-11-11_11-34

Reference Issues

@mreishus mreishus self-assigned this Nov 11, 2020
@matticbot
Copy link
Contributor

@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 11, 2020
@mreishus mreishus requested review from lcollette, sixhours and a team November 11, 2020 17:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 11, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
account        -55 B  (-0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~6 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks        -55 B  (-0.0%)       +1 B  (+0.0%)
async-load-design               -55 B  (-0.0%)       -7 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus
Copy link
Contributor Author

Note: This needs to wait for the migration D52536-code to be completed before merging

Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for D52536-code

@mreishus
Copy link
Contributor Author

D52536-code has been run.

@mreishus mreishus merged commit 7727346 into master Nov 16, 2020
@mreishus mreishus deleted the add/wp-color-scheme-ocean branch November 16, 2020 22:42
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants