Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav unification: Example of extending sakura to work on nav-unification #47292

Closed
wants to merge 2 commits into from

Conversation

mreishus
Copy link
Contributor

@mreishus mreishus commented Nov 10, 2020

Overview

This is an example for #47040, where I point out that calypso color schemes that we port to wp-admin will need a small amount of changes to work in calypso+nav-unification as well.

Screenshots

Before (Calypso Nav Unification Off, Calypso Nav Unification On)
2020-11-10_14-10

After (Calypso Nav Unification Off, Calypso Nav Unification On)
2020-11-10_14-17

Reference Issues

@matticbot
Copy link
Contributor

@mreishus mreishus changed the title Nav-Unifiation: Example of extending sakura to work on nav-unification Nav unification: Example of extending sakura to work on nav-unification Nov 10, 2020
@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 10, 2020
@mreishus
Copy link
Contributor Author

mreishus commented Nov 10, 2020

It's possible that these variables should be merged.

--color-sidebar-menu-hover-heading-background + --color-sidebar-menu-hover-background

--color-sidebar-menu-hover + --color-sidebar-menu-hover-text

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus
Copy link
Contributor Author

mreishus commented Nov 11, 2020

This needs to be updated now that these are pushed:

Aiming to do it today

Edit: Done

@mreishus mreishus force-pushed the add/sakura-nav-unification branch from b779c56 to 4eef47d Compare November 11, 2020 20:34
@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:10
@frontdevde
Copy link
Contributor

Closing in favor of #47783

@frontdevde frontdevde closed this Nov 26, 2020
@mreishus mreishus deleted the add/sakura-nav-unification branch November 11, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants