Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav-unification: Selected submenu color is chosen by variable #47291

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

mreishus
Copy link
Contributor

Changes proposed in this Pull Request

  • When the nav unification flag is on, the expandable submenu will have customizable colors for its currently selected item. Previously, they were hardcoded to white fg and transparent bg.

Testing instructions

2020-11-10_13-24

@mreishus mreishus added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 10, 2020
@mreishus mreishus self-assigned this Nov 10, 2020
@matticbot
Copy link
Contributor

@mreishus mreishus requested a review from a team November 10, 2020 19:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2020
@mreishus mreishus mentioned this pull request Nov 10, 2020
94 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mreishus mreishus merged commit 92e2913 into master Nov 10, 2020
@mreishus mreishus deleted the add/nav-unification-submenu-variables-2 branch November 10, 2020 19:53
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants