-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Schemes: Add Aquatic and hide Ocean #47273
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~52 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~125 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as per testing instructions and can confirm:
- Ocean and Aquatic themes look identical
- When having selected Ocean in production this change will show Aquatic as selected and show the expected colors.
I know what's the usual reaction when people see temporary code. I'll personally make sure it will be followed upon :)
Sounds good! With that, LGTM 👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5157902 Thank you @marekhrabe for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
This is a phase one of #47256 (comment). Please refer to the plan to understand the scope of this PR.
Changes proposed in this Pull Request
I know what's the usual reaction when people see temporary code. I'll personally make sure it will be followed upon :)
Testing instructions
/me/account
on this branch and confirm the UI shows "aquatic" as the active schemePhase one of #47256
Reference Issues