Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masterbar: remove from loading state #47106

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Masterbar: remove from loading state #47106

merged 1 commit into from
Nov 5, 2020

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented Nov 4, 2020 •
edited
Loading

Changes proposed in this Pull Request

  • Remove masterbar from loading state until we have shipped Nav Unification to 100% of users

Testing instructions

  • load calypso
  • make sure masterbar doesn't appear in loading state
  • check both without ?flags=nav-unification and with ?flags=nav-unification
Before After

Relates to #47044 (comment)

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/remove-masterbar-from-loading-state

@cpapazoglou cpapazoglou added [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 4, 2020
@cpapazoglou cpapazoglou self-assigned this Nov 4, 2020
jsnajdr
jsnajdr approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 👍

until we have shipped Nav Unification to 100% of users

I'd say remove it for good 🙂 The masterbar placeholder interferes when loading pages that don't have a masterbar (Signup, Gutenberg) or have it in different design or color (UI with non-default color theme, customized OAuth login pages for Woo or CrowdSignal). Then you'll see a blue stripe for a while that doesn't match to anything in the fully loaded UI.

Removing the masterbar and showing a placeholder that's as-generic and as-gray as possible solves these issues.

@cpapazoglou cpapazoglou merged commit a6e48a4 into master Nov 5, 2020
@cpapazoglou cpapazoglou deleted the update/remove-masterbar-from-loading-state branch November 5, 2020 06:55
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 5, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees

@cpapazoglou cpapazoglou

Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpapazoglou @matticbot @jsnajdr