Nav Unification: Improve 'selected' detection

[mreishus]

Changes proposed in this Pull Request

• Change the method that <MySitesSidebarUnifiedItem> uses to detect "selected" items

Example

path = "/posts/example.com?flags=nav-unification"
url = "/posts/example.com"

path === url was not true in this case, but itemLinkMatches(url, path) is.

Testing instructions

• Visit http://calypso.localhost:3000/plans/example.com?flags=nav-unification
• The purchases menu item should be darker than the rest
  

Related to #45435

[matticbot]

Test live: https://calypso.live/?branch=fix/unified-sidebar-selected

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~14 bytes added 📈 [gzipped])

name                                          parsed_size           gzip_size
async-load-my-sites-sidebar-unified-switcher        +46 B  (+0.0%)      +14 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[obenland]

[obenland]

@Automattic/lighthouse Is that failing check to be expected in PRs that don't mention you?

[lezama]

looks like a random error in github actions, I just re ran the tests and everything is green now, thank for checking @obenland 🥇