-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[markdown] Fix lint errors in packages/components
#45809
Merged
scinos
merged 2 commits into
fix/disable-lint-rules-for-markdown-codeblocks
from
fix/markdown-lint-packages-components
Sep 22, 2020
Merged
[markdown] Fix lint errors in packages/components
#45809
scinos
merged 2 commits into
fix/disable-lint-rules-for-markdown-codeblocks
from
fix/markdown-lint-packages-components
Sep 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Sep 22, 2020
scinos
removed
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Sep 22, 2020
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
griffbrad
approved these changes
Sep 22, 2020
matticbot
added
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Sep 22, 2020
tyxla
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚢
matticbot
removed
the
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
label
Sep 22, 2020
scinos
added a commit
that referenced
this pull request
Sep 22, 2020
* Disable some lint rules for codeblocks in markdown files * [markdown] Fix lint errors in `apps/notifications` (#45803) * [markdown] Fix lint errors in `client` (#45804) * [markdown] Fix lint errors in `packages/babel-plugin-transform-wpcalypso-async` (#45805) * [markdown] Fix lint errors in `packages/calypso-color-schemes` (#45807) * [markdown] Fix lint errors in `packages/calypso-polyfills` (#45808) * [markdown] Fix lint errors in `packages/components` (#45809) * [markdown] Fix lint errors in `packages/data-stores` (#45810) * [markdown] Fix lint errors in `packages/eslint-plugin-wpcalypso` (#45811) * [markdown] Fix lint errors in `packages/i18n-calypso` (#45812) * [markdown] Fix lint errors in `packages/i18n-calypso-cli` (#45813) * [markdown] Fix lint errors in `packages/material-design-icons` (#45814) * [markdown] Fix lint errors in `packages/media-library` (#45815) * [markdown] Fix lint errors in `packages/photon` (#45816) * [markdown] Fix lint errors in `packages/popup-monitor` (#45817) * [markdown] Fix lint errors in `packages/react-i18n` (#45818) * [markdown] Fix lint errors in `packages/request-external-access` (#45819) * [markdown] Fix lint errors in `packages/social-previews` (#45820) * [markdown] Fix lint errors in `packages/viewport` (#45821) * [markdown] Fix lint errors in `packages/viewport-react` (#45822) * [markdown] Fix lint errors in `packages/webpack-extensive-lodash-replacement-plugin` (#45823) * [markdown] Fix lint errors in `packages/webpack-inline-constant-exports-plugin` (#45824) * [markdown] Fix lint errors in `packages/wpcom.js` (#45825) * [markdown] Fix lint errors in `packages/wpcom-proxy-request` (#45826) * [markdown] Fix lint errors in `packages/calypso-build` (#45806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We want to lint the code blocks inside Markdown files to follow our coding style.
Changes
This PR fixes all markdown errors in
packages/components
Testing instructions
Run
./node_modules/.bin/eslint --ext .md --ext .md.js --ext .md.javascript --ext .md.jsx packages/components
, there should be no errors