Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[markdown] Fix lint errors in packages/components #45809

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Sep 22, 2020

Background

We want to lint the code blocks inside Markdown files to follow our coding style.

Changes

This PR fixes all markdown errors in packages/components

Testing instructions

Run ./node_modules/.bin/eslint --ext .md --ext .md.js --ext .md.javascript --ext .md.jsx packages/components, there should be no errors

@matticbot
Copy link
Contributor

@scinos scinos requested a review from a team September 22, 2020 09:50
@scinos scinos self-assigned this Sep 22, 2020
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 22, 2020
@scinos scinos removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 22, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 22, 2020
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚢

@scinos scinos merged commit 23dac9d into fix/disable-lint-rules-for-markdown-codeblocks Sep 22, 2020
@scinos scinos deleted the fix/markdown-lint-packages-components branch September 22, 2020 18:10
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 22, 2020
scinos added a commit that referenced this pull request Sep 22, 2020
* Disable some lint rules for codeblocks in markdown files

* [markdown] Fix lint errors in `apps/notifications` (#45803)
* [markdown] Fix lint errors in `client` (#45804)
* [markdown] Fix lint errors in `packages/babel-plugin-transform-wpcalypso-async` (#45805)
* [markdown] Fix lint errors in `packages/calypso-color-schemes` (#45807)
* [markdown] Fix lint errors in `packages/calypso-polyfills` (#45808)
* [markdown] Fix lint errors in `packages/components` (#45809)
* [markdown] Fix lint errors in `packages/data-stores` (#45810)
* [markdown] Fix lint errors in `packages/eslint-plugin-wpcalypso` (#45811)
* [markdown] Fix lint errors in `packages/i18n-calypso` (#45812)
* [markdown] Fix lint errors in `packages/i18n-calypso-cli` (#45813)
* [markdown] Fix lint errors in `packages/material-design-icons` (#45814)
* [markdown] Fix lint errors in `packages/media-library` (#45815)
* [markdown] Fix lint errors in `packages/photon` (#45816)
* [markdown] Fix lint errors in `packages/popup-monitor` (#45817)
* [markdown] Fix lint errors in `packages/react-i18n` (#45818)
* [markdown] Fix lint errors in `packages/request-external-access` (#45819)
* [markdown] Fix lint errors in `packages/social-previews` (#45820)
* [markdown] Fix lint errors in `packages/viewport` (#45821)
* [markdown] Fix lint errors in `packages/viewport-react` (#45822)
* [markdown] Fix lint errors in `packages/webpack-extensive-lodash-replacement-plugin` (#45823)
* [markdown] Fix lint errors in `packages/webpack-inline-constant-exports-plugin` (#45824)
* [markdown] Fix lint errors in `packages/wpcom.js` (#45825)
* [markdown] Fix lint errors in `packages/wpcom-proxy-request` (#45826)
* [markdown] Fix lint errors in `packages/calypso-build` (#45806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants