removes checkoutFooter and applies the variation #4525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasartoni
added
[Status] Needs Review
| @@ -72,17 +71,7 @@ var SupportingText = React.createClass( { | |||
| }, | |||
|
|
|||
| render: function() { | |||
| if ( abtest( 'checkoutFooter' ) === 'noFooter' ) { | |||
| return null; | |||
There was a problem hiding this comment.
This file probably needs to be removed completely. cc: @scruffian for some help / guidance here.
breezyskies
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
I added a commit to remove |
scruffian
added
[Status] Needs Review
|
Thanks @scruffian! Tested and everything looks good. 👍 |
breezyskies
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes the A/B Test and applies the variation as: #3307
Review:
cc @breezyskies