Nav sidebar: Add active style to sidebar nav items and home button to ensure text is white while clicked #44418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remains white while clicked
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
|
Caution: This PR affects files in the FSE Plugin on WordPress.com D46846-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
p-jackson
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
This is great thanks @andrewserong! Tested the "Add New Page" button too and it all LGTM.
matticbot
removed
the
[Status] Needs Review
This was referenced Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny PR to ensure that the text in the buttons in the nav sidebar are white while clicked.
Changes proposed in this Pull Request
&:not( [aria-disabled='true'] ):activeselector to the.wpcom-block-editor-nav-itemand.wpcom-block-editor-nav-sidebar-nav-sidebar__home-buttonclasses. Thearia-disabledspecificity is required so that we override thecomponents-button:not([aria-disabled="true"]):activeselector in Gutenberg.Screenshot (before)
Screenshot while clicking an item in the nav sidebar list:
Screenshot (after)
Screenshot while clicking an item in the nav sidebar list:
Testing instructions
cd apps/full-site-editing && yarn build && npx wp-env startlocalhost:4013/wp-adminWbutton to open the nav sidebar