Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple buttons #42658

Closed
wants to merge 4 commits into from
Closed

Decouple buttons #42658

wants to merge 4 commits into from

Conversation

eoigal
Copy link
Contributor

@eoigal eoigal commented May 26, 2020

Changes proposed in this Pull Request

  • The PR will try to decouple the login and subscribe buttons used in the non-subscriber view in the premium content block

Ref: #41850

I plan to use recent changes to block context to allow nested blocks to know what the container's selected plan ID is so it can be used to determine if those blocks should be rendered or not.

Testing instructions

  • Apply PR and make sure sync'd with sandbox.
  • Go to test FSE site (that is sandboxed).
  • Test adding a premium content block to a post.
  • Test that the buttons are rendered ok in the editor and in the published post.
  • Test that you can remove all buttons and add them again inside the logged out (non-subscriber) view - you shouldn't be able to add a Premium content button to the subscriber view OR outside the Premium content container.

@eoigal eoigal added [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Earn labels May 26, 2020
@eoigal eoigal self-assigned this May 26, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D43956-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@eoigal eoigal linked an issue May 26, 2020 that may be closed by this pull request
@eoigal eoigal removed Earn [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 27, 2020
@eoigal eoigal closed this May 27, 2020
@mmtr mmtr deleted the decouple-buttons branch June 11, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Premium Content: Decouple buttons from the block
2 participants