-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types: Fix bad type #39868
Types: Fix bad type #39868
Conversation
Test live: https://calypso.live/?branch=fix/typecheck |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~31194 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~1770043 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~6006673 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~2660753 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Moment.js Locales (~108666 bytes added 📈 [gzipped])
Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Stats were bad, accurate stats:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as stated
Changes proposed in this Pull Request
The overlap of the
MediaActions
type name was causingtsc
to error with the following cryptic message:Fix the error (and the
typecheck
job/script) by renaming the type toIMediaActions
.Introduced in #39057 / #39048
Testing instructions
typecheck
job works on CI (has type errors as before, but finishes and reports)npm run typecheck
has the same behavior as the job - type errors but completes and reports