Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types: Fix bad type #39868

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Types: Fix bad type #39868

merged 1 commit into from
Mar 9, 2020

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Mar 4, 2020

Changes proposed in this Pull Request

The overlap of the MediaActions type name was causing tsc to error with the following cryptic message:

…/wp-calypso/node_modules/typescript/lib/tsc.js:78602
                throw e;
                ^

Error: Debug Failure. Unexpected node.
Node 75 was unexpected.
    at getDeclarationSpaces
…

Fix the error (and the typecheck job/script) by renaming the type to IMediaActions.

Introduced in #39057 / #39048

Testing instructions

  • typecheck job works on CI (has type errors as before, but finishes and reports)
  • npm run typecheck has the same behavior as the job - type errors but completes and reports

@matticbot
Copy link
Contributor

@sirreal sirreal requested review from Addison-Stavlo, jeraldjuice and a team March 4, 2020 13:40
@sirreal sirreal self-assigned this Mar 4, 2020
@sirreal sirreal added [Status] Ready to Merge Build [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 4, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~31194 bytes added 📈 [gzipped])

name      parsed_size         gzip_size
manifest    +173714 B  (new)   +31194 B  (new)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~1770043 bytes added 📈 [gzipped])

name                   parsed_size         gzip_size
entry-gutenboarding     +2246467 B  (new)  +589264 B  (new)
entry-main              +1477588 B  (new)  +376280 B  (new)
entry-jetpack-cloud     +1430754 B  (new)  +364750 B  (new)
entry-login              +999754 B  (new)  +270890 B  (new)
entry-domains-landing    +614977 B  (new)  +168859 B  (new)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~6006673 bytes added 📈 [gzipped])

name                      parsed_size         gzip_size
woocommerce                +2062316 B  (new)  +548534 B  (new)
post-editor                +1891000 B  (new)  +521011 B  (new)
checkout                   +1340521 B  (new)  +329474 B  (new)
purchases                   +973744 B  (new)  +231513 B  (new)
domains                     +884067 B  (new)  +203378 B  (new)
gutenberg-editor            +835782 B  (new)  +224630 B  (new)
stats                       +812972 B  (new)  +203462 B  (new)
settings                    +529793 B  (new)  +137947 B  (new)
comments                    +520973 B  (new)  +122256 B  (new)
jetpack-connect             +519493 B  (new)  +136584 B  (new)
activity                    +474418 B  (new)  +120971 B  (new)
help                        +459309 B  (new)  +114463 B  (new)
plugins                     +456527 B  (new)  +117854 B  (new)
reader                      +445156 B  (new)  +116882 B  (new)
settings-writing            +444511 B  (new)  +113158 B  (new)
plans                       +439761 B  (new)  +116032 B  (new)
marketing                   +427508 B  (new)  +107638 B  (new)
security                    +408310 B  (new)  +106318 B  (new)
media                       +374299 B  (new)  +100988 B  (new)
people                      +363820 B  (new)   +93510 B  (new)
themes                      +362904 B  (new)   +96679 B  (new)
concierge                   +311450 B  (new)   +76315 B  (new)
posts                       +309367 B  (new)   +81837 B  (new)
posts-custom                +307055 B  (new)   +81165 B  (new)
notification-settings       +304210 B  (new)   +76991 B  (new)
account                     +299388 B  (new)   +80229 B  (new)
email                       +296379 B  (new)   +78801 B  (new)
zoninator                   +287350 B  (new)   +79642 B  (new)
theme                       +287204 B  (new)   +77104 B  (new)
account-close               +277770 B  (new)   +74367 B  (new)
earn                        +277138 B  (new)   +71140 B  (new)
settings-security           +274000 B  (new)   +73668 B  (new)
google-my-business          +273852 B  (new)   +76852 B  (new)
home                        +271285 B  (new)   +73578 B  (new)
checklist                   +266118 B  (new)   +71576 B  (new)
site-blocks                 +265165 B  (new)   +70454 B  (new)
accept-invite               +256691 B  (new)   +68194 B  (new)
happychat                   +243202 B  (new)   +66121 B  (new)
wp-super-cache              +233180 B  (new)   +60737 B  (new)
pages                       +228375 B  (new)   +62728 B  (new)
privacy                     +223823 B  (new)   +59998 B  (new)
hosting                     +221733 B  (new)   +60821 B  (new)
settings-performance        +219337 B  (new)   +60170 B  (new)
import                      +218023 B  (new)   +58266 B  (new)
me                          +216116 B  (new)   +57832 B  (new)
customize                   +187070 B  (new)   +53052 B  (new)
export                      +185119 B  (new)   +50691 B  (new)
settings-discussion         +181169 B  (new)   +47990 B  (new)
feature-upsell              +158367 B  (new)   +39603 B  (new)
signup                      +157964 B  (new)   +39318 B  (new)
devdocs                     +149589 B  (new)   +40323 B  (new)
migrate                     +149461 B  (new)   +40891 B  (new)
hello-dolly                 +110516 B  (new)   +31741 B  (new)
preview                     +107615 B  (new)   +30978 B  (new)
sensei                      +106138 B  (new)   +30206 B  (new)
sites                       +101551 B  (new)   +28983 B  (new)
auth                         +17693 B  (new)    +5212 B  (new)
domain-connect-authorize     +12726 B  (new)    +3637 B  (new)
mailing-lists                 +6547 B  (new)    +1873 B  (new)
root                           +454 B  (new)     +307 B  (new)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2660753 bytes added 📈 [gzipped])

name                                                         parsed_size         gzip_size
async-load-design-blocks                                      +2765750 B  (new)  +647747 B  (new)
async-load-design                                             +1786508 B  (new)  +411734 B  (new)
async-load-design-playground                                  +1705806 B  (new)  +390730 B  (new)
async-load-components-web-preview-component                    +391558 B  (new)  +101197 B  (new)
async-load-my-sites-site-settings-seo-settings-form            +280423 B  (new)   +74661 B  (new)
async-load-post-editor-media-modal                             +268512 B  (new)   +71859 B  (new)
async-load-blocks-calendar-popover                             +239897 B  (new)   +46661 B  (new)
async-load-blocks-inline-help-popover                          +236561 B  (new)   +57373 B  (new)
async-load-signup-steps-domains                                +219436 B  (new)   +52953 B  (new)
async-load-signup-steps-plans                                  +154417 B  (new)   +40893 B  (new)
async-load-signup-steps-clone-point                            +151409 B  (new)   +35119 B  (new)
async-load-my-sites-checklist-wpcom-checklist-component-jsx    +143435 B  (new)   +36150 B  (new)
async-load-emoji-text                                          +128902 B  (new)   +22496 B  (new)
async-load-apps-notifications-index-jsx                        +117816 B  (new)   +34548 B  (new)
async-load-signup-steps-user                                   +113808 B  (new)   +29999 B  (new)
async-load-reader-following-manage                             +109277 B  (new)   +28949 B  (new)
async-load-signup-steps-plans-atomic-store                      +98531 B  (new)   +25905 B  (new)
async-load-layout-guided-tours-component                        +94133 B  (new)   +20297 B  (new)
async-load-blocks-support-article-dialog-dialog                 +84851 B  (new)   +24786 B  (new)
async-load-reader-search-stream                                 +83149 B  (new)   +21668 B  (new)
async-load-blocks-inline-help                                   +62960 B  (new)   +14842 B  (new)
async-load-lib-happychat-connection                             +61513 B  (new)   +17530 B  (new)
async-load-reader-sidebar                                       +55151 B  (new)   +14237 B  (new)
async-load-signup-steps-theme-selection                         +54276 B  (new)   +13690 B  (new)
async-load-my-sites-current-site-domain-warnings                +53302 B  (new)   +13266 B  (new)
async-load-signup-steps-about                                   +45985 B  (new)   +12690 B  (new)
async-load-my-sites-current-site-notice                         +45221 B  (new)   +10878 B  (new)
async-load-signup-steps-clone-credentials                       +43472 B  (new)   +11378 B  (new)
async-load-extensions-woocommerce-app-store-stats               +42860 B  (new)   +12145 B  (new)
async-load-extensions-woocommerce-app-store-stats-referrers     +42148 B  (new)   +11678 B  (new)
async-load-blocks-product-purchase-features-list                +41564 B  (new)    +9682 B  (new)
async-load-blocks-reader-full-post                              +40865 B  (new)   +11051 B  (new)
async-load-my-sites-current-site-stale-cart-items-notice        +40730 B  (new)   +11478 B  (new)
async-load-signup-steps-rewind-form-creds                       +38093 B  (new)   +10215 B  (new)
async-load-layout-guided-tours                                  +36261 B  (new)   +10017 B  (new)
async-load-components-happychat                                 +34609 B  (new)   +11062 B  (new)
async-load-signup-steps-import-url-onboarding                   +30278 B  (new)    +8815 B  (new)
async-load-signup-steps-site-style                              +29570 B  (new)    +9831 B  (new)
async-load-quick-language-switcher                              +28775 B  (new)    +8361 B  (new)
async-load-signup-steps-site-topic                              +27622 B  (new)    +7921 B  (new)
async-load-signup-steps-clone-ready                             +27542 B  (new)    +7622 B  (new)
async-load-post-editor-editor-sharing-accordion                 +25481 B  (new)    +6586 B  (new)
async-load-reader-site-stream                                   +24548 B  (new)    +6806 B  (new)
async-load-reader-feed-stream                                   +24452 B  (new)    +6746 B  (new)
async-load-signup-steps-passwordless                            +24343 B  (new)    +5983 B  (new)
async-load-signup-steps-rewind-migrate                          +24316 B  (new)    +6794 B  (new)
async-load-signup-steps-site                                    +24299 B  (new)    +6197 B  (new)
async-load-components-jetpack-header-inmotion                   +24215 B  (new)    +7229 B  (new)
async-load-signup-steps-creds-confirm                           +22755 B  (new)    +6320 B  (new)
async-load-my-sites-guided-transfer                             +22751 B  (new)    +5557 B  (new)
async-load-signup-steps-creds-permission                        +22629 B  (new)    +6336 B  (new)
async-load-layout-nps-survey-notice                             +22323 B  (new)    +5761 B  (new)
async-load-signup-steps-import-preview                          +20778 B  (new)    +6262 B  (new)
async-load-blocks-jitm-templates-sidebar-banner                 +20161 B  (new)    +6194 B  (new)
async-load-signup-steps-import-url                              +20013 B  (new)    +5665 B  (new)
async-load-blocks-jitm-templates-notice                         +19662 B  (new)    +6093 B  (new)
async-load-signup-steps-site-or-domain                          +19256 B  (new)    +5466 B  (new)
async-load-layout-masterbar-drafts-popover                      +18920 B  (new)    +5794 B  (new)
async-load-blocks-jitm-templates-default                        +18511 B  (new)    +5860 B  (new)
async-load-components-jetpack-header-dreamhost                  +18500 B  (new)    +5587 B  (new)
async-load-layout-community-translator-launcher                 +18258 B  (new)    +5895 B  (new)
async-load-post-editor-editor-author                            +18105 B  (new)    +5220 B  (new)
async-load-signup-steps-clone-destination                       +17875 B  (new)    +4906 B  (new)
async-load-components-jetpack-header-pressable                  +17373 B  (new)    +5313 B  (new)
async-load-lib-preferences-helper                               +16925 B  (new)    +4957 B  (new)
async-load-signup-steps-survey                                  +16569 B  (new)    +4392 B  (new)
async-load-components-jetpack-header-liquidweb                  +16478 B  (new)    +5788 B  (new)
async-load-extensions-woocommerce-app-store-stats-listview      +15665 B  (new)    +4485 B  (new)
async-load-reader-tag-stream-main                               +15574 B  (new)    +4728 B  (new)
async-load-signup-steps-clone-start                             +14076 B  (new)    +4092 B  (new)
async-load-signup-steps-clone-cloning                           +13597 B  (new)    +3968 B  (new)
async-load-signup-steps-rebrand-cities-welcome                  +13001 B  (new)    +3600 B  (new)
async-load-post-editor-editor-location                          +12717 B  (new)    +3803 B  (new)
async-load-components-jetpack-header-bluehost                   +11588 B  (new)    +3361 B  (new)
async-load-signup-steps-reader-landing                          +11449 B  (new)    +3133 B  (new)
async-load-signup-steps-site-type                               +11301 B  (new)    +3173 B  (new)
async-load-signup-steps-site-title                              +11120 B  (new)    +3069 B  (new)
async-load-signup-steps-clone-jetpack                           +10379 B  (new)    +2808 B  (new)
async-load-reader-list-stream                                   +10316 B  (new)    +3013 B  (new)
async-load-components-jetpack-header-eurodns                     +9892 B  (new)    +2476 B  (new)
async-load-signup-steps-site-picker                              +8997 B  (new)    +2611 B  (new)
async-load-lib-abtest-test-helper                                +8982 B  (new)    +3072 B  (new)
async-load-signup-steps-rewind-were-backing                      +8677 B  (new)    +2570 B  (new)
async-load-post-editor-editor-seo-accordion                      +8657 B  (new)    +2795 B  (new)
async-load-signup-steps-creds-complete                           +8632 B  (new)    +2583 B  (new)
async-load-blocks-app-banner                                     +8222 B  (new)    +2909 B  (new)
async-load-components-community-translator                       +8120 B  (new)    +2567 B  (new)
async-load-signup-steps-test-step                                +7944 B  (new)    +2314 B  (new)
async-load-components-signup-site-preview-component              +7206 B  (new)    +2257 B  (new)
async-load-blocks-product-plan-overlap-notices                   +6418 B  (new)    +2037 B  (new)
async-load-components-jetpack-header-woocommerce                 +5609 B  (new)    +1444 B  (new)
async-load-docs-selectors                                        +5591 B  (new)    +1763 B  (new)
async-load-design-typography                                     +5509 B  (new)    +1686 B  (new)
async-load-post-editor-editor-post-formats-accordion             +5212 B  (new)    +1748 B  (new)
async-load-blocks-inline-help-dialog                             +4974 B  (new)    +1961 B  (new)
async-load-post-editor-editor-discussion                         +4950 B  (new)    +1590 B  (new)
async-load-blocks-jitm                                           +4876 B  (new)    +1794 B  (new)
async-load-reader-conversations-stream                           +4448 B  (new)    +1633 B  (new)
async-load-lib-network-connection                                +4116 B  (new)    +1532 B  (new)
async-load-blocks-login-social-connect-prompt                    +3919 B  (new)    +1347 B  (new)
async-load-featured-image                                        +2912 B  (new)    +1036 B  (new)
async-load-components-webpack-build-monitor                      +2552 B  (new)    +1130 B  (new)
async-load-blocks-legal-updates-banner                           +2485 B  (new)    +1063 B  (new)
async-load-blocks-support-article-dialog                         +1021 B  (new)     +448 B  (new)
async-load-components-jetpack-header-milesweb                     +628 B  (new)     +408 B  (new)
async-load-signup-steps-launch-site                               +586 B  (new)     +357 B  (new)
async-load-lib-rubberband-scroll-disable                          +487 B  (new)     +303 B  (new)
async-load-reader-team-main                                       +370 B  (new)     +265 B  (new)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Moment.js Locales (~108666 bytes added 📈 [gzipped])

name                    parsed_size         gzip_size
moment-locale-ru            +4547 B  (new)    +1606 B  (new)
moment-locale-mr            +3437 B  (new)    +1275 B  (new)
moment-locale-bo            +3250 B  (new)    +1074 B  (new)
moment-locale-uk            +3242 B  (new)    +1435 B  (new)
moment-locale-ta            +3026 B  (new)    +1165 B  (new)
moment-locale-be            +2949 B  (new)    +1290 B  (new)
moment-locale-cs            +2882 B  (new)    +1170 B  (new)
moment-locale-ka            +2756 B  (new)     +995 B  (new)
moment-locale-kn            +2755 B  (new)    +1150 B  (new)
moment-locale-ar            +2663 B  (new)    +1186 B  (new)
moment-locale-ne            +2577 B  (new)    +1108 B  (new)
moment-locale-sr-cyrl       +2518 B  (new)    +1091 B  (new)
moment-locale-ar-ly         +2506 B  (new)    +1111 B  (new)
moment-locale-gu            +2505 B  (new)    +1089 B  (new)
moment-locale-el            +2484 B  (new)    +1220 B  (new)
moment-locale-bn            +2473 B  (new)    +1051 B  (new)
moment-locale-sl            +2462 B  (new)     +993 B  (new)
moment-locale-pa-in         +2461 B  (new)    +1022 B  (new)
moment-locale-ml            +2405 B  (new)     +959 B  (new)
moment-locale-hi            +2371 B  (new)    +1077 B  (new)
moment-locale-ug-cn         +2366 B  (new)    +1020 B  (new)
moment-locale-km            +2322 B  (new)    +1010 B  (new)
moment-locale-lt            +2320 B  (new)    +1102 B  (new)
moment-locale-te            +2287 B  (new)     +959 B  (new)
moment-locale-es-us         +2209 B  (new)     +945 B  (new)
moment-locale-es-do         +2209 B  (new)     +946 B  (new)
moment-locale-es            +2192 B  (new)     +940 B  (new)
moment-locale-mn            +2185 B  (new)     +970 B  (new)
moment-locale-sk            +2150 B  (new)     +933 B  (new)
moment-locale-tlh           +2143 B  (new)     +891 B  (new)
moment-locale-my            +2140 B  (new)     +938 B  (new)
moment-locale-hy-am         +2137 B  (new)     +966 B  (new)
moment-locale-hr            +2125 B  (new)     +940 B  (new)
moment-locale-th            +2107 B  (new)     +860 B  (new)
moment-locale-ku            +2091 B  (new)     +976 B  (new)
moment-locale-pl            +2067 B  (new)     +995 B  (new)
moment-locale-si            +2060 B  (new)     +863 B  (new)
moment-locale-tg            +2053 B  (new)     +981 B  (new)
moment-locale-me            +2045 B  (new)     +957 B  (new)
moment-locale-lo            +2044 B  (new)     +812 B  (new)
moment-locale-fa            +2038 B  (new)     +940 B  (new)
moment-locale-sr            +2027 B  (new)     +952 B  (new)
moment-locale-hu            +2018 B  (new)     +932 B  (new)
moment-locale-nl-be         +2002 B  (new)     +940 B  (new)
moment-locale-nl            +1993 B  (new)     +937 B  (new)
moment-locale-fi            +1982 B  (new)     +894 B  (new)
moment-locale-bs            +1975 B  (new)     +877 B  (new)
moment-locale-gom-latn      +1967 B  (new)     +962 B  (new)
moment-locale-he            +1940 B  (new)     +879 B  (new)
moment-locale-ar-sa         +1932 B  (new)     +921 B  (new)
moment-locale-is            +1925 B  (new)     +897 B  (new)
moment-locale-lv            +1895 B  (new)     +849 B  (new)
moment-locale-ca            +1823 B  (new)     +857 B  (new)
moment-locale-tzm           +1821 B  (new)     +653 B  (new)
moment-locale-lb            +1812 B  (new)     +942 B  (new)
moment-locale-ky            +1773 B  (new)     +892 B  (new)
moment-locale-kk            +1762 B  (new)     +875 B  (new)
moment-locale-zh-cn         +1759 B  (new)     +922 B  (new)
moment-locale-az            +1758 B  (new)     +914 B  (new)
moment-locale-zh-tw         +1757 B  (new)     +907 B  (new)
moment-locale-zh-hk         +1752 B  (new)     +908 B  (new)
moment-locale-mk            +1750 B  (new)     +910 B  (new)
moment-locale-bg            +1730 B  (new)     +915 B  (new)
moment-locale-cv            +1693 B  (new)     +813 B  (new)
moment-locale-tzl           +1635 B  (new)     +867 B  (new)
moment-locale-dv            +1574 B  (new)     +818 B  (new)
moment-locale-br            +1548 B  (new)     +837 B  (new)
moment-locale-x-pseudo      +1533 B  (new)     +852 B  (new)
moment-locale-ja            +1533 B  (new)     +771 B  (new)
moment-locale-vi            +1532 B  (new)     +771 B  (new)
moment-locale-ss            +1519 B  (new)     +805 B  (new)
moment-locale-gl            +1519 B  (new)     +738 B  (new)
moment-locale-et            +1498 B  (new)     +768 B  (new)
moment-locale-tr            +1487 B  (new)     +799 B  (new)
moment-locale-ko            +1483 B  (new)     +733 B  (new)
moment-locale-mi            +1478 B  (new)     +749 B  (new)
moment-locale-de-at         +1471 B  (new)     +760 B  (new)
moment-locale-de-ch         +1462 B  (new)     +744 B  (new)
moment-locale-de            +1460 B  (new)     +753 B  (new)
moment-locale-ar-dz         +1451 B  (new)     +686 B  (new)
moment-locale-ar-tn         +1435 B  (new)     +680 B  (new)
moment-locale-ar-ma         +1432 B  (new)     +682 B  (new)
moment-locale-ar-kw         +1432 B  (new)     +681 B  (new)
moment-locale-uz            +1431 B  (new)     +710 B  (new)
moment-locale-cy            +1419 B  (new)     +761 B  (new)
moment-locale-jv            +1415 B  (new)     +738 B  (new)
moment-locale-fy            +1411 B  (new)     +769 B  (new)
moment-locale-yo            +1402 B  (new)     +705 B  (new)
moment-locale-fr            +1388 B  (new)     +727 B  (new)
moment-locale-gd            +1377 B  (new)     +755 B  (new)
moment-locale-eu            +1377 B  (new)     +692 B  (new)
moment-locale-fr-ch         +1373 B  (new)     +724 B  (new)
moment-locale-ms-my         +1372 B  (new)     +722 B  (new)
moment-locale-ms            +1363 B  (new)     +719 B  (new)
moment-locale-ur            +1357 B  (new)     +731 B  (new)
moment-locale-sd            +1356 B  (new)     +755 B  (new)
moment-locale-fr-ca         +1354 B  (new)     +713 B  (new)
moment-locale-id            +1350 B  (new)     +718 B  (new)
moment-locale-ga            +1348 B  (new)     +735 B  (new)
moment-locale-eo            +1339 B  (new)     +734 B  (new)
moment-locale-af            +1332 B  (new)     +728 B  (new)
moment-locale-se            +1327 B  (new)     +708 B  (new)
moment-locale-pt-br         +1316 B  (new)     +702 B  (new)
moment-locale-it-ch         +1312 B  (new)     +721 B  (new)
moment-locale-pt            +1307 B  (new)     +703 B  (new)
moment-locale-it            +1303 B  (new)     +718 B  (new)
moment-locale-sq            +1292 B  (new)     +703 B  (new)
moment-locale-sv            +1282 B  (new)     +699 B  (new)
moment-locale-tet           +1263 B  (new)     +689 B  (new)
moment-locale-en-nz         +1256 B  (new)     +687 B  (new)
moment-locale-en-au         +1256 B  (new)     +686 B  (new)
moment-locale-en-SG         +1252 B  (new)     +687 B  (new)
moment-locale-en-gb         +1252 B  (new)     +686 B  (new)
moment-locale-en-ie         +1251 B  (new)     +686 B  (new)
moment-locale-bm            +1246 B  (new)     +635 B  (new)
moment-locale-en-ca         +1240 B  (new)     +675 B  (new)
moment-locale-ro            +1225 B  (new)     +713 B  (new)
moment-locale-nb            +1225 B  (new)     +645 B  (new)
moment-locale-tl-ph         +1218 B  (new)     +657 B  (new)
moment-locale-en-il         +1217 B  (new)     +667 B  (new)
moment-locale-fo            +1205 B  (new)     +660 B  (new)
moment-locale-tzm-latn      +1189 B  (new)     +566 B  (new)
moment-locale-nn            +1186 B  (new)     +641 B  (new)
moment-locale-mt            +1175 B  (new)     +679 B  (new)
moment-locale-da            +1165 B  (new)     +633 B  (new)
moment-locale-sw            +1161 B  (new)     +632 B  (new)
moment-locale-uz-latn       +1157 B  (new)     +599 B  (new)

Locale data for moment.js. Unless you are upgrading the moment.js library, changes in these chunks are suspicious.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal
Copy link
Member Author

sirreal commented Mar 4, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~31194 bytes added 📈 [gzipped])

App Entrypoints (~1770043 bytes added 📈 [gzipped])

Stats were bad, accurate stats:

Latest push in this branch:
Commit: cc7d733c6876ac0804f5aef2b64c1ceebb1aacaa
Author: sirreal
At: 2020-03-04T13:35:38Z
Message: Fix tsc breaking type error
Chunk Groups Delta:
no changes in production JS
Chunks Delta:
name                                              stat_size           parsed_size    gzip_size
woocommerce                                           -11 B  (-0.0%)         +0 B         +0 B
post-editor                                           -11 B  (-0.0%)         +0 B         +0 B
manifest                                               +0 B                  +0 B         -4 B  (-0.0%)
gutenberg-editor~media~settings~settings-writing      -11 B  (-0.0%)         +0 B         +0 B
async-load-design-blocks                              -11 B  (-0.0%)         +0 B         -1 B  (-0.0%)

Total                                                 -44 B                  +0 B         -5 B

http://iscalypsofastyet.com/branch?branch=fix/typecheck

@sirreal sirreal removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 4, 2020
Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as stated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants