Sticky panel: add event listener for resizing to update measurements. #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes sticky state when mobile viewport is detected, otherwise components like EditorGroundControl could get stuck in an incorrect state. (Obscuring the UI.)
mtias
added
[Feature] Post/Page Editor
|
Haven't reviewed the code, but this fixes the issue I experienced! Nice work! 👍 |
| updateIsSticky: function() { | ||
| var isSticky = window.pageYOffset > this.threshold; | ||
|
|
||
| if ( viewport.isMobile() ) { | ||
| return; | ||
| return this.setState( { isSticky: false } ); |
There was a problem hiding this comment.
Do we need to set the state if the stickiness didn’t change?
There was a problem hiding this comment.
We could definitely include a this.state.isSticky check in the if.
aduth
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
mtias
force-pushed
the
fix/sticky-panel-update-routine
branch
from
362d979
to
65f0c84
Compare
mtias
force-pushed
the
fix/sticky-panel-update-routine
branch
from
65f0c84
to
73029cc
Compare
mtias
added
[Status] Needs Review
|
The changes here look and work well 👍 I am noticing that we have similar issues with resize handling of the pinned editor toolbar. This can be addressed separately.
|
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
Thanks for the feedback. We can keep tweaking it after it's in, but it's nice to get something basic there to prevent the main issue of "hidden All Posts link". |
mtias
added a commit
that referenced
this pull request
Nov 23, 2015
Sticky panel: add event listener for resizing to update measurements.
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes sticky state when mobile viewport is detected, otherwise components like EditorGroundControl could get stuck in an incorrect state. (Obscuring the UI.)
Testing
isMobilechecks), then scroll up in mobile view, then resize back to regular window size.@jasmussen do you mind taking a look at this?