Fix an error where calypsoifyGutenberg global object was undefined #37900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We tried to reference the global declaration even though it was undefined. To fix, we reference it directly from the window object, which declares a variable and sets its value to undefined.
noahtallen
added
[Status] Needs Review
noahtallen
changed the title
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Addison-Stavlo
approved these changes
Nov 23, 2019
noahtallen
deleted the
fix/global-object-runtime-err-calypsoify-gutenberg
branch
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to reference the global declaration even though it was undefined.
To fix, we reference it directly from the window object, which declares the variable and sets its value to undefined. Previously, the entire variable was undefined, causing the runtime error.
Props to @Addison-Stavlo for finding this!
Testing:
Test that the "Back" button shows up in your local install when editing an FSE page. This bug does not happen with gutenframe since the global object exists there.