Block-Editor: reorder Jetpack and CoBlocks categories

[gwwar]

Changes proposed in this Pull Request

Part of #35876 this moves Jetpack and CoBlocks categories below other categories.

Note that the core/blocks store uses the array order of whatever we dispatched via setCategories, so doing things like changing a block's category slug name or translated title currently do not affect ordering.

Before	After

Questions / Notes

• Open question for @apeatling and @simison, would we like this to affect all site types or just Atomic and Simple, excluding self-hosted Jetpack sites?
• If folks have a different category ordering in mind let me know.
• Is domReady a decent event for waiting for all blocks/columns registration to settle? If there's something more appropriate, I can update.

Testing instructions

• Apply D34488-code
• Sandbox widgets.wp.com
• Open the Block Editor from wp-admin or WordPress.com/block-editor
• Verify that the new category order matches as expected in an Atomic and Simple Site
• Verify that no reordering happens for Jetpack (standalone) sites

[matticbot]

Test live: https://calypso.live/?branch=update/block-category

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[simison]

would we like this to affect all site types or just Atomic and Simple, excluding self-hosted Jetpack sites?

Yeah, I think you should exclude self-hosted Jetpack sites; I don't think it's in the spirit of Gutenberg to re-organize categories for self-hosted sites but totes fine for WordPress.com which is a more curated experience.

In Jetpack we have site type utils — would that be helpful here too?

cc @jeherve @kraftbj

[kwight]

If folks have a different category ordering in mind let me know.

I would want Reusable blocks above the branding too, but that's pure bike-shedding.

[gwwar]

I would want Reusable blocks above the branding too

It's not part of the category listing. I'd probably need to make a core PR

[simison]

I would want Reusable blocks above the branding

That can get pretty complicated since it gets loaded async when you first time open the block picker. :-/

[gwwar]

In Jetpack we have site type utils — would that be helpful here too?

I'm considering if we should just sort out the two common bundles for Simple/Atomic vs Jetpack first #34476 or have a temporary check/feature flag. We already do have a window object that should be able to tell the difference between environments but it's something definitely to be tidied.

🤔 I'll probably go with a simple check and we can see about sorting out bundles as part of upcoming sprints. I wouldn't want to keep it in this state for long.

[gwwar]

In Jetpack we have site type utils — would that be helpful here too?

Thanks, wpcomGutenberg didn't have the props I was hoping for (though we can update that). window._currentSiteType should work provided that our hashing works for Jetpack versions to avoid this loading for older Jetpack installs.

Edit: 🤔 this might be tricky. I guess folks are downloading latest based on this issue Automattic/jetpack#12397

[simison]

wpcomGutenberg didn't have the props I was hoping for (though we can update that). window._currentSiteType should work provided that our hashing works for Jetpack versions to avoid this loading for older Jetpack installs.

I'd looove to get those moved to wpcomGutenberg for clarity, out of the global root. Not a requirement in this PR but it would be great to get it done at some point soon. :-)

🤔 I'll probably go with a simple check and we can see about sorting out bundles as part of upcoming sprints. I wouldn't want to keep it in this state for long.

+1, sounds like a plan!

[gwwar]

This one is ready for another round of 👀. I've added some temporary checks so this only runs for Simple and Atomic. D34488-code has been rebuilt with https://circleci.com/gh/Automattic/wp-calypso/475666

[gwwar]

Desktop failures here are unrelated as this change doesn't touch any Calypso app bundles

[kwight]

Confirmed behaviour across all three platforms 👍

[gwwar]

Thanks for the reviews @kwight @simison! I'll land this next week unless folks had any other requests for behavior/feedback. cc @apeatling if the category listing seems okay

[apeatling]

Ordering looks good 👍