Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: font-size scrub from 10px to 11px #352

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Plugins: font-size scrub from 10px to 11px #352

merged 1 commit into from
Nov 20, 2015

Conversation

rickybanister
Copy link

  • I worked through the plugins css to remove a bunch of instances of font-size: 10px; and replacing it with 11px (our minimum size for text)
  • I made tweaks to align things that moved due to the change to 11px.
  • I noticed while doing this that there were styles that had broken related to the Jetpack Disconnect button.
  • I found references to colors that weren't using the scss variables, I took care of those.

Before:
screen shot 2015-11-20 at 4 31 04 pm

screen shot 2015-11-20 at 4 29 44 pm

After:

screen shot 2015-11-20 at 4 30 56 pm

screen shot 2015-11-20 at 4 29 09 pm

cc @MichaelArestad

Plugins: working through the plugins css to remove all instances of `…
caabee0 
…font-size: 10px;` and replacing it with 11px (our minimum size for text)

I also made tweaks to align things that moved due to the change to 11px.
I also noticed while doing this that there were styles that had broken related to the Jetpack Disconnect button.
@rickybanister rickybanister added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Jetpack Plugins labels Nov 20, 2015
@rickybanister rickybanister self-assigned this Nov 20, 2015
@enejb
Copy link
Member

enejb commented Nov 20, 2015

Code wise it works and looks much better! Thanks 👍

@MichaelArestad
Copy link
Contributor

This looks good. Both code and design.

@MichaelArestad MichaelArestad added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 20, 2015
rickybanister pushed a commit that referenced this pull request Nov 20, 2015
Merge pull request #352 from Automattic/fix/plugin-font-sizes
5656823 
Plugins: font-size scrub from 10px to 11px
@rickybanister rickybanister merged commit 5656823 into master Nov 20, 2015
@rickybanister rickybanister deleted the fix/plugin-font-sizes branch November 20, 2015 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rickybanister rickybanister

Labels
Jetpack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickybanister @enejb @MichaelArestad @scruffian