Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the in-product support UI on Delete Site screen #3342

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

dllh
Copy link
Member

@dllh dllh commented Feb 16, 2016

Repro:

  1. Go to http://calypso.localhost:3000/settings/delete-site/:site:
  2. Click the "Contact Support" link

At present, it looks like this and points to https://en.support.wordpress.com/contact/:

contact-delete-site

Since we now have a support experience inside Calypso, we should point there instead. I'm not super clear on whether we'd want to take over the current tab or still target _blank, though I feel like we probably want the former.

The change updates the link to point to /help/contact. With the change, clicking on the contact button will load the contact form in the current tab.

See also #3341, which is a very similar change and a bit of a slam dunk review. :)

@dllh dllh added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Support All things related to WordPress.com customer support. labels Feb 16, 2016
@dllh dllh self-assigned this Feb 16, 2016
@dllh dllh force-pushed the update/delete-site-support-link branch from 43bb9f8 to 6cbb71e Compare February 18, 2016 19:33
@dllh dllh force-pushed the update/delete-site-support-link branch from 6cbb71e to 9e3e78e Compare February 19, 2016 01:58
@omarjackman
Copy link
Contributor

Looks good to me 👍

dllh added a commit that referenced this pull request Feb 19, 2016
Use the in-product support UI on Delete Site screen
@dllh dllh merged commit 02ade95 into master Feb 19, 2016
@dllh dllh deleted the update/delete-site-support-link branch February 19, 2016 12:51
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Support All things related to WordPress.com customer support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants