Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Update calypso-build's Jest config #33351

Merged
merged 12 commits into from
May 29, 2019

Conversation

ockham
Copy link
Contributor

@ockham ockham commented May 27, 2019

Changes proposed in this Pull Request

  • Move logic to properly handle file-loader and style-loader import statements from Calypso's test/ dir into calypso-build. (These should live there, since it's also that package that handles those statements in production code.)
  • Properly set up Enzyme.

Discovered while working on #33154, where these commits originated.

Testing instructions

Are unit tests still passing?

@ockham ockham added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build Testing Packages labels May 27, 2019
@ockham ockham requested review from sirreal and a team May 27, 2019 12:02
@ockham ockham self-assigned this May 27, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are unit tests still passing?

verified unit tests are still passing 👍

packages/calypso-build/jest.config.js Outdated Show resolved Hide resolved
@ockham ockham force-pushed the update/calypso-build-jest-config branch from c752ed6 to 78516fd Compare May 28, 2019 12:01
@blowery
Copy link
Contributor

blowery commented May 28, 2019

Nice, thanks @ockham!

@ockham ockham merged commit 8d77bf3 into master May 29, 2019
@ockham ockham deleted the update/calypso-build-jest-config branch May 29, 2019 08:58
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants