try: add storybook to showcase progressbar from calypso-ui #33166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
commented
May 20, 2019
flootr
force-pushed
the
try/dev-docs-storybook
branch
from
cfc2896 to
87bfbc9
Compare
ockham
force-pushed
the
try/calypso-ui-with-progress-bar
branch
2 times, most recently
from
f0aac15 to
8d2673a
Compare
ockham
force-pushed
the
try/calypso-ui-with-progress-bar
branch
2 times, most recently
from
2f88de9 to
fa3b22b
Compare
ockham
force-pushed
the
try/calypso-ui-with-progress-bar
branch
from
fe18aed to
a450b95
Compare
blowery
force-pushed
the
try/calypso-ui-with-progress-bar
branch
from
a450b95 to
a9d808e
Compare
|
Closing after merge of #38496. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Note: At the moment this is just an exploration to see whether it's possible to use Storybook to showcase our components. Also this is based on #33154 to be able to import
<ProgressBar />from@automattic/calypso-ui.Testing instructions
First run
And then
npm run storybook. Here's what you should see:cc @blowery