-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickup new xgettext version to fix #3239 #3292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deBhal
added
i18n
[Status] In Progress
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
and removed
[Status] In Progress
labels
Feb 12, 2016
This is the diff, looking good (apparently also catches some other skipped strings)
|
akirk
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Feb 14, 2016
deBhal
added a commit
that referenced
this pull request
Feb 14, 2016
Pickup new xgettext version to fix #3239
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've updated xgettext-js Automattic/xgettext-js#6. Once we publish that package, this PR picks up the new version
To verify the fix:
make translate
in this branchcalypso-strings.php
npm update xgettext-js
make translate
againcalypso-strings.php
against the old one.We want to verify that:
P.S. I'm on holiday with my family at the moment, but need to get this in before the i18n weekly kit goes out on Monday. If the PR looks good, I'd appreciate having it merged :)