Desktop: Fix selectors for notification button #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjangda
added
[Status] Needs Review
| this.onToggleNotifications(); | ||
| clearNotificationBar: function() { | ||
| // TODO: find a better way. seems to be react component state based | ||
| let notificationsLink = this.getNotificationLinkElement(); |
There was a problem hiding this comment.
Super minor, but when we have an identifier that we don't reassign to (notificationsLink, in this case), we generally use const.
This fixes the notifications shortcut in the desktop app to catch up with the new masterbar updates.
mjangda
force-pushed
the
fix/desktop-notif-shortcut
branch
from
49b635c
to
378bda4
Compare
mjangda
added a commit
that referenced
this pull request
Feb 10, 2016
Desktop: Fix selectors for notification button
scruffian
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix for the notifications shortcut in the desktop app to catch up with the new masterbar updates.
To Test
make run