Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic Editor: removes After the Deadline from the toolbar #31865

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Classic Editor: removes After the Deadline from the toolbar #31865

merged 1 commit into from
Apr 23, 2019

Conversation

rodrigoi
Copy link
Contributor

@rodrigoi rodrigoi commented Mar 29, 2019 •
edited
Loading

Changes proposed in this Pull Request

Removes the Proofread Writing button from the Classic Editor toolbar, along with all related files.

Before After
Screen Shot 2019-03-29 at 03 20 22 Screen Shot 2019-03-29 at 03 21 40

Testing instructions

  • Opt out of the Block Editor on any WordPress.com site.
  • Edit or Create a Post or Page with the Classic Editor.
  • Verify that there are no regressions with the editing experience.

Part of #28550

@rodrigoi rodrigoi self-assigned this Mar 29, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/remove-atd-from-classic-editor

@rodrigoi rodrigoi mentioned this pull request Mar 29, 2019
Merged
@rodrigoi rodrigoi requested a review from a team March 30, 2019 00:10
@rodrigoi rodrigoi added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 30, 2019
kwight
kwight approved these changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@kwight kwight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couldn't find any regressions.

@rodrigoi rodrigoi force-pushed the update/remove-atd-from-classic-editor branch from 95a1412 to 583eaea Compare April 23, 2019 20:45
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~362 bytes removed 📉)

name   parsed_size           gzip_size
build       -362 B  (-0.0%)      -38 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~15964 bytes removed 📉)

name         parsed_size           gzip_size
post-editor     -15964 B  (-0.7%)    -5117 B  (-1.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@rodrigoi rodrigoi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 23, 2019
@rodrigoi rodrigoi merged commit 7924244 into master Apr 23, 2019
@rodrigoi rodrigoi deleted the update/remove-atd-from-classic-editor branch April 23, 2019 21:01
@rodrigoi rodrigoi mentioned this pull request May 3, 2019
Closed
rodrigoi added a commit that referenced this pull request May 6, 2019
@rodrigoi
Revert "Classic Editor: removes after the deadline button from the cl…
909cfd7 
…assic editor toolbar (#31865)"

This reverts commit 7924244.
@rodrigoi rodrigoi mentioned this pull request May 6, 2019
Merged
Copons pushed a commit that referenced this pull request May 8, 2019
@Copons
Revert "Classic Editor: removes After the Deadline from the toolbar" (#…
e9e5fc2 
…32841)

* Revert "Classic Editor: removes after the deadline button from the classic editor toolbar (#31865)"

This reverts commit 7924244.

* Enabling After the Deadline proofreading for VIP sites on WordPress.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwight kwight kwight approved these changes

Assignees

@rodrigoi rodrigoi

Labels
[Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigoi @matticbot @kwight