i18nUtils: accept 3-letter locale slugs #3177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3175, by updating the regex filter in i18nUtils.getLanguage() to accept locales with three-letter slugs.
If you run
config('languages').forEach( (lang) => i18nUtils.getLanguage( lang.langSlug ) ? null : console.log(lang.name) )
(e.g. by adding it to the bottom ofclient/lib/i18n-utils/utils.js
and callingmake test
) you see a list of languages that occur in the config but return null from getLanguage():These languages all have 3 letter slugs, so I've updated the filter in
i18n-utils
to allow them and added a test for one of them.