People: First pass at disabling the invite form until invitee added #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
force-pushed
the
update/people-invites-disable-button
branch
from
eed4030 to
f79d23c
Compare
|
@lezama – I think this is ready to go for now. I'd like to iterate on what happens after submitting the form and handling I will create other issues for those. |
This was referenced Feb 21, 2016
ebinnion
added
[Status] Needs Review
ebinnion
force-pushed
the
update/people-invites-disable-button
branch
from
8a40840 to
5417626
Compare
|
|
||
| // If there are invitees, and there are no errors, let's check | ||
| // if there are any pending validations. | ||
| return some( usernamesOrEmails, ( value ) => { |
There was a problem hiding this comment.
I think this would read clearer if we use every instead of some.
There was a problem hiding this comment.
We quickly discussed this in Slack, and the condition would be ! every( /* Logic here */ ). I'm not sure that that is more readable. So, we're going to go ahead and ship.
lezama
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
LGTM if you don't feel like my suggestion is an improvement :) |
ebinnion
added a commit
that referenced
this pull request
Feb 24, 2016
…e-button People: First pass at disabling the invite form until invitee added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a user could land on the
/people/new/$siteroute and submit the form right away. This change ensure that there is at least one username or email address before allowing submission.In the near future, we'll also want to handle these conditions.
What happens after a form is submitted? Disable the form until another username or email is added?What iflocalStoragewas cleared and site is not set?