PostShare block maintenance: localize, CSS migration and fixes, ESLint a11y fix #31022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up usage of
i18n-calypso
The
ConnectionsList
component doesn't use anything from thelocalize
wrapper, which is therefore removed.On the other hand,
NoConnectionsNotice
gets wrapped bylocalize
and doesn't need to be passed thetranslate
prop from the parent. It also gets its own file.Migrate CSS styles to webpack
Fairly straighforward, no complications.
Fix some CSS glitches in
NoConnectionsNotice
Before: notice the useless margin under the notice and unwanted border radius on the left:
After: both glitches get fixed:
Remove an ESLint-offending
tabIndex
prop fromCalendarButton
The component ignores the prop anyway, so it's an easy win. Verify that tab navigation around the share block works as expected (after you connect a social account):