Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Remove spurious chars from logged-out #3054

Merged
merged 1 commit into from
Feb 3, 2016

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Feb 3, 2016

There's a closing component-and-conditional /> } in logged-out which is a leftover from copying from multi-site where this is actually needed.

To test:

  • Incognito window, calypso.localhost:3000/design
  • The issue is visible on master if you search for a term that will return only few themes so you see the bottom of the page (try 'Espresso').
  • Verify it's fixed on this branch

@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] High Address as soon as possible after BLOCKER issues [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 3, 2016
@ockham ockham self-assigned this Feb 3, 2016
@ockham ockham added this to the Themes: Maintenance milestone Feb 3, 2016
@seear
Copy link
Contributor

seear commented Feb 3, 2016

👍

ockham added a commit that referenced this pull request Feb 3, 2016
…rious-chars

Themes: Remove spurious chars from logged-out
@ockham ockham merged commit 29d2093 into master Feb 3, 2016
@ockham ockham deleted the remove/themes-logged-out-spurious-chars branch February 3, 2016 21:21
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] High Address as soon as possible after BLOCKER issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants